twemproxy icon indicating copy to clipboard operation
twemproxy copied to clipboard

Make include guards unique.

Open elfring opened this issue 11 years ago • 2 comments

Some include guards do not fit to the expected naming convention of the C language standard. This detail can be fixed by the deletion of leading underscores.

The probability for name clashes can also be reduced by the addition of a kind of universally unique identifier as a suffix.

This update suggestion corresponds to the issue "reserved identifier violation".

elfring avatar Dec 31 '13 14:12 elfring

would prefer NC_EVENT_H renamed as NC_EVENT_H without the uuid as suggested in https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29

manjuraj avatar Dec 31 '13 22:12 manjuraj

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 18 '19 15:07 CLAassistant