Markus Elfring

Would you like to add more error handling for return values from functions like the following? - [fclose](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fclose.html "Close a stream.") ⇒ [saveAsVox](https://github.com/sylefeb/VoxModSynth/blob/f81037b23160edde124c73109b71542e12912e47/main.cpp#L585) - [fread](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fread.html "Binary input") ⇒ [loadFromVox](https://github.com/sylefeb/VoxModSynth/blob/f81037b23160edde124c73109b71542e12912e47/main.cpp#L517)

Use of angle brackets around file names for include statements

2

Would you like to [replace any double quotes](https://github.com/hasherezade/libpeconv/blob/4832b3ada146d0c7f0327d217a03a92bb82f8693/libpeconv/include/peconv.h#L3 "Check inclusion style") by [angle brackets around file names for include statements](https://stackoverflow.com/questions/21593/what-is-the-difference-between-include-filename-and-include-filename "What is the difference between #include and #include “filename”?")?

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of compound operators](https://docs.oracle.com/javase/specs/jls/se17/html/jls-15.html#jls-15.26 "Description for assignment operators") accordingly....

reserved identifier violation

7

I would like to point out that identifiers like “[`_Tp`](https://github.com/mne-tools/mne-cpp/blob/6b5de08f13d63f31ceeff2943ea5c9b08e06f203/libraries/utils/generics/circularbuffer.h#L68 "Update candidate")” and “[`_MatrixType`](https://github.com/mne-tools/mne-cpp/blob/6b5de08f13d63f31ceeff2943ea5c9b08e06f203/include/3rdParty/eigen3/Eigen/src/LU/PartialPivLU.h#L17 "Another update candidate")” [do eventually not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier "Do not declare an identifier which is reserved for...

Remove unnecessary null pointer checks

6

[Extra null pointer checks are not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [FwdCompData::fwd_free_comp_data](https://github.com/mne-tools/mne-cpp/blob/6b5de08f13d63f31ceeff2943ea5c9b08e06f203/libraries/fwd/fwd_comp_data.cpp#L206 "FwdCompData::fwd_free_comp_data function") - [MneCTFCompData](https://github.com/mne-tools/mne-cpp/blob/6b5de08f13d63f31ceeff2943ea5c9b08e06f203/libraries/mne/c/mne_ctf_comp_data.cpp#L127 "Destructor for...

Improve exception safety with smart pointers

1

Would you like to wrap any pointers with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”? Update candidates: - [FiffSimulator](https://github.com/mne-tools/mne-cpp/blob/6b5de08f13d63f31ceeff2943ea5c9b08e06f203/applications/mne_rt_server/plugins/fiffsimulator/fiffsimulator.cpp#L82) - [GpuInterpolationItem](https://github.com/mne-tools/mne-cpp/blob/6b5de08f13d63f31ceeff2943ea5c9b08e06f203/libraries/disp3D/engine/model/items/common/gpuinterpolationitem.cpp#L76)

Use of angle brackets around file names for include statements

20

Would you like to [replace any double quotes](https://github.com/FidoProject/Fido/blob/0af4306319f6d9d8243c20babddb3c565277791a/include/Fido.h#L4) by [angle brackets around file names for include statements](http://stackoverflow.com/questions/21593/what-is-the-difference-between-include-filename-and-include-filename)?

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....

Support the configuration of a shell environment before tracing a passed command

6

The tool “uftrace” supports tracing for passed commands. These commands are directly executed so far. But this execution configuration should be adjusted for some use cases. We are used to...

Improving descriptions for data output according to function arguments and return values

6

[The information “The uftrace tool supports recording function arguments and/or return values …” is provided](https://github.com/namhyung/uftrace/blob/ea48ca7acde23fe4053c725d706d264e1bd4c470/doc/uftrace-record.md#arguments "Storage of function data"). I would appreciate if the documentation can be extended so that...