Markus Elfring

[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [ImageRef](https://github.com/ppwwyyxx/OpenPano/blob/024b96180943814a4090ea041c39d08b05d49cfc/src/stitch/imageref.hh#L20 "Destructor for ImageRef") - [release](https://github.com/ppwwyyxx/OpenPano/blob/024b96180943814a4090ea041c39d08b05d49cfc/src/stitch/imageref.hh#L29...

Completion of error handling

5

Would you like to add more error handling for return values from functions like the following? - [printf](http://pubs.opengroup.org/onlinepubs/9699919799/functions/printf.html) ⇒ [parse_options](https://github.com/Xfennec/progress/blob/9c31d02b650cd4a1ffe98c747d499c8d24bee657/progress.c#L442) - [signal](http://pubs.opengroup.org/onlinepubs/9699919799/functions/signal.html) ⇒ [main](https://github.com/Xfennec/progress/blob/9c31d02b650cd4a1ffe98c747d499c8d24bee657/progress.c#L758)

I guess that a different program design will be needed for your function "[int_handler](https://github.com/Xfennec/progress/blob/9c31d02b650cd4a1ffe98c747d499c8d24bee657/progress.c#L750)". - [The variables "flag_monitor" and "flag_monitor_continous"](https://github.com/Xfennec/progress/blob/9c31d02b650cd4a1ffe98c747d499c8d24bee657/progress.c#L66) should [use the data type "sig_atomic_t"](https://www.securecoding.cert.org/confluence/display/c/SIG31-C.+Do+not+access+shared+objects+in+signal+handlers). - The functions "[endwin](http://pubs.opengroup.org/onlinepubs/007908775/xcurses/endwin.html)"...

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....

Improve const-correctness

2

I suggest to add the key word "const" to the type specifiers for parameters like the following. - opts, imbe_d (function "[saveImbe4400Data](https://github.com/szechyjs/dsd/blob/master/dsd.h#L227)") - parity (function "[decode](https://github.com/szechyjs/dsd/blob/c23ff4fe0c9d592ff78b12313aeeff697af25b09/Hamming.hpp#L96)") Would you like to...

Extensions for source code search patterns in more structured ways

3

[The answer “Flawfinder works by using a built-in database of C/C++ functions with well-known problems, …” was puplished](https://dwheeler.com/flawfinder/#how_work "How does Flawfinder work?"). Can these source code analysis approaches be structured...

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of compound operators](https://262.ecma-international.org/12.0/#sec-assignment-operators "Description for assignment operators") accordingly....

[An extra null pointer check is not needed in a function](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like [the destructor for the class “ot_data_t_buffer_cpu”](https://github.com/griegler/octnet/blob/2406d4c1efaa0051d54ebb8de7b22f1190ad55b1/core/include/octnet/cpu/buffer.h#L43 "Update candidate").

Completion of error handling

6

Would you like to add more error handling for return values from functions like the following? - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [update_mask_value](https://github.com/Syllo/nvtop/blob/fb2e112fb35203a00e87078f577dee2655d517b1/src/nvtop.c#L115) - [printf](http://pubs.opengroup.org/onlinepubs/9699919799/functions/printf.html "Print formatted output") ⇒ [main](https://github.com/Syllo/nvtop/blob/fb2e112fb35203a00e87078f577dee2655d517b1/src/nvtop.c#L179)

Recheck source code in coap_dtls_new_context()

8

[The implementation of the function “coap_dtls_new_context”](https://github.com/obgm/libcoap/blob/a6ff63b15921076c0b73c92d1141f7f66f06c7ce/src/coap_gnutls.c#L300 "Update candidate") does not contain a goto statement. The jump label “fail” can not be reached. How do you think about to adjust (or...