Markus Elfring
Markus Elfring
I would like to point out that identifiers like “[`_CMD_OPTIONS_H_`](https://github.com/searchivarius/nmslib/blob/b0d05cac24b51cdfac498bac6a09460428fe09f3/similarity_search/include/cmd_options.h#L18 "Update candidate")” and “[`__HASH_TABLE_HELPERS_H__`](https://github.com/searchivarius/nmslib/blob/24d7b4c71e269b518b1e1824ab455fe02f637d47/similarity_search/include/falconn/core/hash_table_helpers.h#L1 "Another update candidate")” [do eventually not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for...
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of compound operators](https://docs.oracle.com/javase/specs/jls/se17/html/jls-15.html#jls-15.26 "Description for assignment operators") accordingly....
I would like to point out that an identifier like “[`__bundleCache`](https://github.com/fredakilla/GPlayEngine/blob/466cac36a864a6a16cf70b1c927de295e1e7dad8/src/core/Bundle.cpp#L36 "Update candidate")” [does not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier "Do not declare an identifier which is reserved for the compiler implementation.") to the...
Would you like to add more error handling for return values from functions like the following? - [pthread_mutex_init](https://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_mutex_init.html "Initialize a mutex.") ⇒ [InitNamedEvent](https://github.com/microsoft/ProcDump-for-Linux/blob/1fb637759985a2838d4b0e3ae08f4173da2daa94/src/Events.c#L66) - [malloc](https://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [WaitForMultipleObjects](https://github.com/microsoft/ProcDump-for-Linux/blob/1fb637759985a2838d4b0e3ae08f4173da2daa94/src/Handle.c#L157)
I suggest to reuse a higher level build system so that powerful checks for software features will become easier. - [CMake](https://cmake.org/ "Building software with CMake") - [Autotools](https://www.gnu.org/software/autoconf/autoconf.html#introduction "Building software with...
[The following source code structure](https://github.com/hnes/libaco/blob/88e25d518ef258b06f9c228f59edc2dc947f116f/aco.c#L309 "Update candidate") is repeated a few times. ``` … …* p = malloc(…); assertalloc_ptr(p); … ``` How do you think about to combine it into...
I would like to point out that identifiers like “[`_CODECS_H_`](https://github.com/medooze/media-server/blob/371242612e4a4d839301f6cd986cc676c93a955d/include/codecs.h#L1 "Update candidate")” and “[`_MEDIA_H_`](https://github.com/medooze/media-server/blob/f00fd54cb89680165c1008a3ceabb5e0c17401c8/include/media.h#L1 "Another update candidate")” [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the...
[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [MultiConf](https://github.com/medooze/media-server/blob/c368a2c67cea5e15d913d3652868def722641e7c/src/multiconf.cpp#L53 "Destructor for MultiConf") - [RTMPChunkInputStream](https://github.com/medooze/media-server/blob/c368a2c67cea5e15d913d3652868def722641e7c/src/rtmp/rtmpchunk.cpp#L80...
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://www.php.net/manual/en/language.operators.assignment.php#language.operators.assignment.arithmetic "Description for assignment operators") accordingly....