Easwar Swaminathan
Easwar Swaminathan
@ash2k Could we have some benchmarks like what we have on https://github.com/grpc/grpc-go/pull/7786.
We've made some recent changes to introduce a new encoding API which addresses this issue. See: https://github.com/grpc/grpc-go/pull/7356 Would appreciate your feedback on how the new changes work for you. Also,...
Should we mention the environment variables in the release note? Or at least in the PR description?
And `vet-proto` is failing because we made a recent change to the codegen. So, it might be worth rebasing to master.
Also, i went ahead and marked some comments as resolved to reduce the noise in the review.
@zasweq : You seem to have requested changes on this PR. Do you mind taking a pass? Thanks.
As part of https://github.com/grpc/grpc-go/pull/6749, we did end up removing a bunch of env vars. But some still remain: 1. `LeastRequestLB`: https://github.com/grpc/grpc-go/blob/9affdbb28e4be9c971fadfb06fb89866863ef634/internal/envconfig/envconfig.go#L39 This has been defaulting to `false` from the time...
@eshitachandwani : Maybe this is good for another round of review. Can you please take another pass? Thanks
Thank you, @hugehoo, for your contribution!