Easwar Swaminathan comments

Results 540 comments of


                                            Easwar Swaminathan

orca: server side custom metrics implementation

Thanks for the review.

orca: server side custom metrics implementation

This should be good for another pass. PTAL. Thanks.

orca: server side custom metrics implementation

Based on our offline discussion, did not add the delete API back. So, things stay as-is for now. PTAL. Thanks.

orca: server side custom metrics implementation

Also changed the interceptor implementation to not pull the recorder out of the context, but use it directly.

Grab comment from proto file, similar to protoc-gen-go

Thank you for the PR !!

Flaky test: Test/Fallback in grpclb

https://github.com/grpc/grpc-go/runs/6289811002?check_suite_focus=true

Flaky test: Test/Fallback in grpclb

https://github.com/grpc/grpc-go/runs/6497446292?check_suite_focus=true

Flaky test: Test/Fallback in grpclb

https://github.com/grpc/grpc-go/runs/7530707497?check_suite_focus=true

xds: propagate xds client transport error to watchers

@menghanl : This seems to be similar in spirit to https://github.com/grpc/grpc-go/issues/4121. Do we want to do this at this point in time? Do we need consensus among the languages.

clusterresolver: deflake eds_impl tests

Also, if you have more comments, it would be great if you could mark the ones which have been handled satisfactorily as "resolved". That way, we can track just the...