Easwar Swaminathan
Easwar Swaminathan
The issue of making `attributes.Attributes` comparable is tracked under #3611. We have fixed the WRR implementation to pass weights through `attributes`. But it still also passes the same through `metadata....
I do see usages in the ringhash balancer. https://github.com/grpc/grpc-go/blob/db79903af928ca8307700d83123a7702881c4e3c/xds/internal/balancer/ringhash/ring.go#L123 @menghanl : Was this intentional? Can we use the attributes field here? Also, we should probably investigate if we can completely...
Yes, rename `ch` to `C` and add a comment, something to this effect ``` // C is the underlying channel on which values sent using the SendXxx() methods are delivered....
There is no way for the client to know that the server handler has crashed (this information cannot be communicated from the server to the client). The responsibility of the...
https://github.com/grpc/grpc-go/runs/7028912000?check_suite_focus=true
https://github.com/grpc/grpc-go/runs/7033753689?check_suite_focus=true
https://github.com/grpc/grpc-go/runs/7079511748?check_suite_focus=true
https://github.com/grpc/grpc-go/runs/7103470543?check_suite_focus=true
https://github.com/grpc/grpc-go/runs/7551451115?check_suite_focus=true