Easwar Swaminathan

Results 540 comments of Easwar Swaminathan

Sorry for suggesting that we could possibly send the whole route instead of sending only the `auto_host_rewrite` field, as specified in A60. After reading A60, I realized that sending the...

I'm picking this one up as I'm going to be looking into the priority policy for the connection churn issue anyways.

The xDS client accepts a list of supported resource types as part of its configuration at creation time here: https://github.com/grpc/grpc-go/blob/e8167363406cc5a2da7befab1bfc5e4c21bdd264/internal/xds/clients/xdsclient/xdsconfig.go#L60 We need a simple test where - We define a...

@arjan-bal : Can you please take a first look and see if this seems ok.

This is currently blocked on the implementation of gRFC A74.

`ClientConn.Close` does its best to shutdown everything before returning. See: https://github.com/grpc/grpc-go/blob/b8a0fc99579fe3ae9643ab9fc3bad8e7f92077cc/clientconn.go#L1135 But, as you rightly point out, if one of those sub-components spawns a goroutine but does not wait for...

> Yes, as stated in the issue description, log statements are being issued after close, which will race with the logging subsystem shutdown during graceful application shutdown Do you have...

I see that the CI is failing for `TestResolverBadServiceUpdate_NACKedWithoutCache`. We recently fixed this. Would you please rebase your PR to master. Thanks.

@twz123 We had a discussion about this PR during our GitHub issues/PR scrub. Can I request you to split these into separate PRs. The change to the graceful_switch LB policy...