Easwar Swaminathan
Easwar Swaminathan
Open issues requiring attention from @dfawley : https://github.com/grpc/grpc-go/pull/7498#discussion_r1736930278 https://github.com/grpc/grpc-go/pull/7498#discussion_r1736968684
I feel like at this point, I'm happy with how the code looks now and I'm very unlikely to notice anything that might improve the code. Will let @dfawley review...
I'm sorry, but I merged a change recently that refactored the logging implementations. So, this PR might have significant merge conflicts now.
Fixed by https://github.com/grpc/grpc-go/pull/7701.
https://github.com/grpc/grpc-go/actions/runs/11710477647/job/32616845920?pr=7814
https://github.com/grpc/grpc-go/actions/runs/12306496136/job/34348329478?pr=7924
@purnesh42H : There are still a few comments from me from a long time ago that are unaddressed. Could you please ensure that you have replied to all open comments....
@purnesh42H : The release not is very clear though. I think we need to fix that soon so that we don't scramble during release time.
> > @danielzhaotongliu: Could you please mark comments that you initiated as "resolved" once they have been sufficiently addressed. That makes it easier to stamp the final approval on the...
Can one of the owners/maintainers please take a look? Thanks.