grpc-go icon indicating copy to clipboard operation
grpc-go copied to clipboard

grpctest: add test coverages of `ExitIdle`

Open hugehoo opened this issue 7 months ago • 1 comments

Fixes: https://github.com/grpc/grpc-go/issues/8118

  • Add test cases for
    • [X] ExitIdle()
    • [X] ExitIdleOne()
    • [X] UpdateClientConnState
    • [x] ResolverError

RELEASE NOTES: N/A

hugehoo avatar May 31 '25 15:05 hugehoo

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 81.82%. Comparing base (a5e7cd6) to head (705625a). :warning: Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8375      +/-   ##
==========================================
- Coverage   82.48%   81.82%   -0.67%     
==========================================
  Files         414      413       -1     
  Lines       40464    40518      +54     
==========================================
- Hits        33376    33152     -224     
- Misses       5736     5990     +254     
- Partials     1352     1376      +24     

see 48 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 31 '25 15:05 codecov[bot]

Hey @hugehoo , is this ready for review or is it still a work in progress? If it is ready for review , please request a review and unassign yourself so that we can review it.

eshitachandwani avatar Jun 19 '25 05:06 eshitachandwani

Hey @hugehoo , is this ready for review or is it still a work in progress? If it is ready for review , please request a review and unassign yourself so that we can review it.

hi, i'm still working on this pr, testing is still broken. i think i can request a review within this weekend.

hugehoo avatar Jun 20 '25 04:06 hugehoo

Hey @hugehoo are you still working on this PR?

eshitachandwani avatar Jul 07 '25 05:07 eshitachandwani

This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.

github-actions[bot] avatar Jul 20 '25 06:07 github-actions[bot]

Hey @hugehoo are you still working on this PR?

sorry for late, i requested for review now

hugehoo avatar Jul 20 '25 08:07 hugehoo

Hey @hugehoo , The name of this test was recently changed : tests (tests, 1.24, arm64, ubuntu-24.04-arm) , and that is why the test is stuck. Can you merge master so that the test can run again?

eshitachandwani avatar Jul 22 '25 09:07 eshitachandwani

Hey @hugehoo , The name of this test was recently changed : tests (tests, 1.24, arm64, ubuntu-24.04-arm) , and that is why the test is stuck. Can you merge master so that the test can run again?

@eshitachandwani thx for the info, i just merged it and run the test again.

hugehoo avatar Jul 22 '25 11:07 hugehoo

This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.

github-actions[bot] avatar Jul 28 '25 13:07 github-actions[bot]

@eshitachandwani : Maybe this is good for another round of review. Can you please take another pass? Thanks

easwars avatar Jul 28 '25 22:07 easwars

Thank you, @hugehoo, for your contribution!

easwars avatar Aug 15 '25 17:08 easwars