Easwar Swaminathan comments

Results 540 comments of


                                            Easwar Swaminathan

Enhance parseDialTarget Function to Support Named Pipes

I'll close this PR at this point. But feel free to file an issue if you'd like to discuss anything further.

xds: Prevent flakes in server cert provider tests

It looks the ADS rpc handler on the go-control-plane is essentially processing one request (which includes ACK/NACK as well) at a time, serially. And it calls the `OnStreamRequest` callback as...

clusterimpl: use gsb.UpdateClientConnState instead of switchTo, on receipt of config update

@aranjans : Could you please handle any open comments here. Thanks.

switching to stubserver

@purnesh42H : Please feel free to merge once my last two comments have been addressed.

outlierdetection: Support health listener for ejection updates

Should we release note this? It is not something that is going to be very visible to users, but if at all there is some behavior change that they observe,...

xds/balancer/clusterimpl: Replace run goroutine with grpcsync.CallbackSerializer

I also updated the PR description and also got rid of the release notes since we don't need release notes for non-user visible behavior changes.

xds/balancer/clusterimpl: Replace run goroutine with grpcsync.CallbackSerializer

> The core modification in this diff appears to be transitioning `UpdateClientConnState` into a blocking operation. We should explicitly mention this in the commit description. `UpdateClientConnState` always needs to be...

cluster_resolver: wait until the configs have been propagated to all the children

I've started an internal discussion thread to discuss what would be the correct fix for this. Please bring your thoughts to that thread.

cluster_resolver: wait until the configs have been propagated to all the children

I think the approach will change non-trivially from here, so we can close this for now. Thanks.

pickfirst: New pick first policy for dualstack

Adding @dfawley for a second set of eyes. The changes are close to LGTM. I'm making another pass to see if I have more comments. But I feel it is...