Easwar Swaminathan
Easwar Swaminathan
The dependecy changes test is failing. @dfawley and I had looked at it previously. @purnesh42H : You should be using the status code from the grpc package and not from...
> @easwars I see ringhash_experimental policy already has picker update in sync with the config update [here](https://github.com/grpc/grpc-go/blob/master/xds/internal/balancer/ringhash/ringhash.go?rgh-link-date=2024-05-02T07%3A25%3A34Z#L302) and similarly i see the same for many other lb policies. Am I...
Fixes internal issue: https://b.corp.google.com/issues/408227990
@purnesh42H : FYI since the migration PR got rolled back. If this goes in before that eventual roll-forward, we need to ensure that we don't lose track of this fix....
etcd seems to have made plenty of releases since the last update on this issue. So, we are not blocked anymore.
We seem to have removed the `MD.String` method in https://github.com/grpc/grpc-go/pull/7372. My memory is very hazy here. Was the plan that we add it back, but only print keys that we...
@apolcyn : Are we still waiting on https://github.com/grpc/grpc/pull/38933, or should we close this?
> I checked the internal usages and found that adding a private method will break code generated using GoMock Hmm.. at least internally, mocking is not recommended for Go. I'm...
There are still a whole lot of comments which are not wrapped at 80-cols. Could you please take care of that. Also, please don't mark comments as resolved. It is...
> Related question: I see quite a few calls with a `nil` `pool` - `mem.NewBuffer(&someDataSlice, nil)`. Why not swap this with a type cast like this `mem.SliceBuffer(someDataSlice)`? No need to...