Dylan T. comments

Results 863 comments of


                                            Dylan T.

Small movements may not trigger `PlayerMoveEvent` until the player rotates

The position delta issue would still exist whether or not the player could trigger an event by rotating. So it's not really relevant.

SurvivalBlockBreakHandler: Take swimming, flying, climbing and effects into account

Closing in favour of #6500

Lots of items named ENCHANTED_BOOK in Creative Inventory

These are most likely the ones whose enchantments aren't implemented yet

Lots of items named ENCHANTED_BOOK in Creative Inventory

Yeah, because this discards unknown enchantments: https://github.com/pmmp/PocketMine-MP/blob/5a926a79cb97f284c64c754d3f60fba8348435b8/src/item/Item.php#L316

Lots of items named ENCHANTED_BOOK in Creative Inventory

> Some items have enchantments that are already known, but none in the creative inventory has an enchantment. The ones that appear in this mess are indeed the ones that...

fix(Explosion): don't apply motion if the event's cancelled

Not really possible to knockback on base EntityDamageEvent since it doesn't have a source to knockback away from. It's possible it could be supported from EntityDamageByBlockEvent. However using existing knockback...

Next steps for improving GC performance and configurability

Unfortunately the GC doesn't give us much outward stats information, so it's difficult to see what types of objects it's spending time on. I only experimentally verified that `Server`, `Player`...

Next steps for improving GC performance and configurability

Related to #6781

Flowable blocks now can't be placed inside liquid

~A simpler and more robust method would be to alter `Liquid::canBeReplacedBy()` and add a check for `isFlowable()`.~ Never mind, apparently I dreamed that such a method existed.

6161 implement interface common block properties

Closing due to lack of response to review comments