Dylan T.
Dylan T.
This should be less noisy now as of https://github.com/pmmp/PocketMine-MP/commit/4c3a2ef46ed15dbdccec415d78603a23fea41fb1
This function already has an epsilon built in, it shouldn't be needed. Also not clear if this might cause unintended side effects.
> Fixes blocks not placing right next to the player at certain positions Would be nice to have some examples so this can be tested
I don't like this change. It'll affect all callers of getNearbyEntities(), which could have all kinds of unintended side effects. Glitchiness at large coordinates is to be expected, since there's...
This is expected behaviour currently. The actions in an InventoryTransaction are not required to be in any particular order. We actually shuffle them intentionally to prevent dependence on implicit client...
> Though, if I did want it to be ordered, how would I go on doing so? Correct me if I'm wrong, but it doesn't seem like there's an API...
Linking to #4647 which has the same root cause and also to #5092
Fixed by https://github.com/pmmp/PocketMine-MP/commit/d18b393ccb0f9f3f2f1d95598a20e51beed8ebb6
Probably better to just add a map to the `EffectManager`, and then add a method like `EffectManager::getRemainingDuration(Effect $effect) : int`. However, this would still be a behavioural BC break, because...
This also affects performance because of `InventoryManager`'s need to compare NBT for prediction verification.