PocketMine-MP icon indicating copy to clipboard operation
PocketMine-MP copied to clipboard

6161 implement interface common block properties

Open CoderJoeW opened this issue 1 year ago • 3 comments

Introduction

The goal of this is to give plugins an easier way of accessing common properties of blocks such as facing and on/off

Relevant issues

Fixes #6161

CoderJoeW avatar Jul 03 '24 21:07 CoderJoeW

@dktapps Just want to get a quick review of this to make sure its headed in the intended direction

CoderJoeW avatar Jul 04 '24 03:07 CoderJoeW

Would this be better utilized trait, I think the is the direction most items like this follow.

pocketmine\block\Bell.php#42

cjmustard avatar Jul 04 '24 03:07 cjmustard

Would this be better utilized trait, I think the is the direction most items like this follow.

pocketmine\block\Bell.php#42

Probably should use the trait as there is Horizontal and AnyFacing traits that could be used

Possibly out of scope? Would likely fit more into another PR for cleaning up the code

CoderJoeW avatar Jul 04 '24 04:07 CoderJoeW

This PR has been marked as "Waiting on Author", but we haven't seen any activity in 7 days.

If there is no further activity, it will be closed in 28 days.

Note for maintainers: Adding an assignee to the PR will prevent it from being marked as stale.

github-actions[bot] avatar Dec 06 '24 02:12 github-actions[bot]

Closing due to lack of response to review comments

dktapps avatar Dec 09 '24 02:12 dktapps