Dylan T.

It looks like BuilderTools was the source of these issues. Hopefully this should catch the problem earlier: https://github.com/pmmp/PocketMine-MP/commit/258923cc78bc2fc5f9504e450cb3ba43a484d2c3 It would be better if this could be pre-validated at the point...

That's really the wrong way to add proxy data anyway. You don't want to accidentally send a custom proxy packet to a client.

> I have no real problem with the current implementation. It seems fine to me and is a first step towards a better inventory system. > > Another follow-up I...

Few issues remain with the PR: - [x] `BlockInventoryWindow` subclasses have minimum 3 constructor parameters - annoying for plugins, lots of room to break things - I'm thinking something like...

Double chests have also proven to be a pain in the ass and will likely be an obstacle for #6147 as well

Only remaining major issue is around the lengthened usage for opening inventory windows to players. I didn't quite decide how to deal with it. There are a few things to...

I think finishing this with nice APIs may require differentiating between "container" and "menu" blocks. Container blocks have inventories (chest, shulkerbox, hopper, furnace, etc) while menu blocks don't (anvil, crafting...

I'm also wondering whether the player's main inventory window handling should be redone as part of this PR. We'd probably need to introduce a separate "hotbar" PlayerInventoryWindow type to facilitate...

Alright. I think I'm finally done with this

In the interest of avoiding branch rot I'm going to get this merged, the final result won't look too different from this anyway. Pls let me know if there are...