Dylan T.

Results 460 comments of Dylan T.

This sounds unnecessarily restrictive... requiring that the operand of `!` be a boolean should be more than enough.

If you're using Worker it won't actually crash, it'll just bork the task involved. https://github.com/pmmp/pthreads/issues/34

I have no idea why this is different in vanilla vs PM. If anyone wants to investigate this, please feel free.

On further inspection I think this is missing from more stuff than just cake.

Well, the most common source of disabling is server shutdown, so I'd say this doesn't need to address that problem. Even if we disallow plugin disabling, the server still has...

I think this is OK, but I have my doubts that relying on the ordering of `getPlugins()` is the best idea. Since the ordering of arrays isn't related to the...

A solution to the issue above ^ is complicated due to the potential for plugins to get randomly disabled at runtime.

Stop being needy. There is not enough reviewer manpower to go around and I have much more important things to worry about right now. I'll review it when I have...

Dumping this in the API isn't the right way to do it. It should be masked at the network layer similar to how transaction slot predictions are handled.