dimxy
dimxy
btw RBF is also supported for some UTXO coins, for e.g. BTC. First obvious option for use of RBF is withdrawal of coins. Another option is to retry of maker...
There is a couple of spots in nft code where we use the "MATIC" const
I suggest removing log dumps inside run_taker_node run_maker_node run_watcher_node in swap_watcher_tests.rs: (https://github.com/KomodoPlatform/komodo-defi-framework/pull/2452/commits/864e7e57af845d6d85fa42d74d5fccd1ebf92112). They dump incomplete logs (before tests calling them finish), so in fact misleading. Instead we should create log...
Watched test failure due to the infura mainnet provider rate limiter: ``` 26 16:43:17, coins::eth:6402] ERROR Couldn't get client version for url https://mainnet.infura.io/v3/c01c1b4cf66642528547624e1d6d9d6b: request MethodCall(MethodCall { jsonrpc: Some(V2), method: "web3_clientVersion",...
To fix this issue I suggest adding the following params, both into the coins file and enable tokens request: - `swap_fee_priority` - legacy, low, medium or high - eip1559 priority...
I think there is something in the code: [here](https://github.com/KomodoPlatform/komodo-defi-framework/blob/b0fd99e8406e67ea06435dd028991caa5f522b5c/mm2src/mm2_main/src/lp_swap/maker_swap.rs#L1089) in spend_taker_payment() we create a tx spending the maker payment tx. Then in the same function we create next MakerSwapCommand::ConfirmTakerPaymentSpend command....
> > It didn't occur here. I tried to swap MOVR for DAI-PLG20 as taker.. makerpayment (DAI-PLG20) was sent by maker, but taker failed to spend it (tx reverted because...
In this PR zhtlc-native-tests now work (as in the current dev branch some fail). But I had to add flavor = "multi_thread" to the zombie_coin_send_dex_fee test. (W/o the 'multi_thread' option...
> I believe you want to change the function to async and remove the usage of block_on and await instead @dimxy > > ```rust > #[tokio::test] > ``` Yes I...
> > "the transaction was rejected by network rules" > > both maker and taker were using [e4e6114](https://github.com/KomodoPlatform/komodo-defi-framework/commit/e4e611426bcb86e726d41a5a6f7ecfadf49d7c46) the tx has empty vin (I have seen the same issue in...