atomicDEX-API improvement(ARRR): improve shielded transactions change notes handling in swaps

Jan 29 '25 10:01 borngraced

tried to swap ARRR with this, but still getting same error

      {
         "event" : {
            "data" : {
               "error" : "taker_swap:1320] mm2src/coins/z_coin.rs:1233] z_coin:500] z_coin:483] GenTxError(SaveChangeNotesError(\"storage:206] NOT NULL constraint failed: received_notes.nf\"))"
            },
            "type" : "TakerFeeSendFailed"
         },
         "timestamp" : 1738160344119
      },

Jan 29 '25 14:01 cipig

tried to swap ARRR with this, but still getting same error

      {
         "event" : {
            "data" : {
               "error" : "taker_swap:1320] mm2src/coins/z_coin.rs:1233] z_coin:500] z_coin:483] GenTxError(SaveChangeNotesError(\"storage:206] NOT NULL constraint failed: received_notes.nf\"))"
            },
            "type" : "TakerFeeSendFailed"
         },
         "timestamp" : 1738160344119
      },

@cipig https://github.com/KomodoPlatform/komodo-defi-framework/pull/2331#issue-2817815195

Jan 29 '25 15:01 borngraced

@cipig can you please retry again? I've made some changes to this PR 🙏🏾

Jan 30 '25 15:01 borngraced

started a swap with https://sdk.devbuilds.komodo.earth/fix-arrr-note-saving/mm2_e735df9-linux-x86-64.zip takerfee ARRR now worked fine, takerpayment failed though:

taker_swap:1700] mm2src/coins/z_coin.rs:1348] z_coin:572] client:878] Rpc(ResponseParseError(JsonRpcError { client_info: "coin: ARRR", request: JsonRpcRequest { jsonrpc: "2.0", id: 334, method: "blockchain.transaction.broadcast", params: [String("0400008085202f89000283aa22dd0800000017a91438b6fd31949ceef35e9ab3d8c25ec5755603e3ae8700000000000000006e6a4c6b6304381d9c67b17521020610f02dfb60f513b41b36221eb0b5c87377f0d48f6ed517848c7c2a793a40c0ac6782012088a914d31a8da756208b326a8294f90f8474f73d210da288210258a9e9b3332e186457ab8d91852fadb2f7bd9dd4d53f6813e5172ce8ec4f3c9cac6800000000b12732006bae22dd0800000001476c2687d8429860995e5ffee5b2c33b4e7de524ad686560599e787d4bc2d52c559d26f60c74a6696255d4bb69374e7234eae0d4ca337d34511b71e2f8d3e2178339f7d89effb8e07c088d9f59720370cff344fd1e995d6bcee157df4c4e19d6f4a8addde098cf8510dba764fec23959f7ede601ee64bb292c120fc2ccbe42dda669c33e817b1a5a0e6c467cf9262b92b39dc2efe62838d36553207b1e5f211cea05c662326b260291de0da2477a544a988f434504438e291c7a74f3219a04c52221626f89655745d2a6b1bff59307ff40b859413cc98be7c461f48b6c6e06150609f73420e1b34eda8d94e68df518ceff18c3d5e5998f31862632519ad4ea8594364d51c9c36b1ae841c591f7dbfa85947534056f176fe65c4086774840fbde80fe0643ec6325bd51f34a0c17ee01202398f5d3d214fe58d32eab90f96b80b1b4dc3de9ae93968a0eaea8f99d0da8a9fc9f9562f6442ca309af12914e244e3fc027243724e3be3baa08ecc8e8ad18707d54b4cd2380d590804456bff023830102352ac2546581ce8a0177ecd4de639f8bdd699bc977b664ab131ca6ee7f4c0866d6ec4e97799523eac8ceeeccd7f497abb590fceeb598e5f3166effdba72b874fd12b942827a91cf5c678a884ced816a779930cc009301098f07a972d86497958111d960175eaa25dc367107906fc15638aa503c870173cbe0ff862028ef31a0e976c4e72d55dc83eadf7504425619061e8b2f671acf84b4218a0874e5221f3fec84ce350db5f26621b65522dee3c14fb7f1014da99d38bd31687e6df65f09641d84c656be94d3c250ee1d875e6a972bc8748ae0d695b911e4a865050c12fae8a4802f410b8e65627d94f917a586dd87fb89a022ff16434100d997a6539e38f57d2cbc2c04ec9abfc51640d7257c1aa7b230648a91f116c23a996eb54453ae42f5cf074459f1a0086cb479f65f4b00b0c2c652ea508cb73ac553727dd726503666911da15dbb4abb614b2aa498473bf5cdc4481e045816dea13d79ce8f114262d50c1965f02a48a22bf5c46f6aa1a924e997858e8ede13a250a5b47cfee9d16e8617f5c356bf46fdfd1b7af1efe741f1325d485cf3e0a7c9d83c05f632e206d8fc7b28ad8c51a5602909e93a595b8932e40d593380143a2fce9be448bbd5e242d24748bad18ba2fdf48369c023b3ac0b0091e47d7245e6420beaee67d047e00bcb1f6426e28912cfd2042fe1e60f61a6ffed2c4d7a244c18d9202a9abb40954b15e29920431438b7e3ac298a8a6e701631397be6b1bd821c7b78251758f781b4cd37128e30ab0ac562d10160385eb40ba7efaf873911bcc2e34e2f12e71ee31a0ca3ec5fbe52369c7bc8aeade98ecd08d04d90fd3fd3d96d7633cb01433eae6b81a69965493518d4586d67e644a7aff39a7766eb8d90a353de0b429f4f3b8aa8ed78d9d82991d73ebf671df521afe529d0c350294af155c7dbda040cb5b45aaf2278316b8cec7781b9c449e6daec29460dcc967dd1c81047238fd5032a6dab0fc2fbde772062820386d842c81b1760c2fe566e587011e69be3cd548f3b82500d753b8e943b17ce8db2eda8560adbf2ceaba836f95a0b0adb56c456b098f29fcb90f4d68b4d7c3fb6afe6e34dc2d9cdacb0ec71c76f5efb1fe957505ab697715eeb5f5c85aa6a7ccad06fdee0427c00d21d5eb98c40e89f953e28758255559301af9ed85da232290c0f9a69d112edc5c315fc10a1f015d229be3abb4a82b6893ef35ff56993f243656001b366900ce7077160a21feb91201a4c2371286f4c64079eb6e6661b28a1c6f46cd2698b99265b7e24309510b452084dd4c34d043413a3948bea0e57b8acdcb9d32b85424e0b1eabf04c06a9ba6273107a01a074728211b3ecd80a90abe3d022ae0344e99aeb52c0eb9eb12ee56968c3c4425ed81cc997161ca0574b935c2c567fc37ed3ca9f65962c09104b9ea330f91dac32f69f0246a7b51b877ef9b60556dd19f61420c5d7ab04889bbc8743bfc04737b9a3628bfbbded722ae7ee08a48fda4c962e06a13867ccfd715f7dc7470958bd9cd12a6119420cdaba817d776736cf0429600abc4df8ceb9d7598c6ed1460f6b88a65359d3a37b866aaba9d6d3fdef612af0d104b0c97e24a8c0e0ac133cb120def1665f0504358fe9bc096587d817ec1b2c21365a092d9f2be9948a27096ba54d57a307048b35337f2d557a9ecd40202acafa5e754c5495cb312be2b6a44e34b95dba6cf8022a89f871ec62ff34c37d16aecc29211188f25c5d309266ba71bcb506b71506bbcaa68e14a3e9f3e5f93bbf20a4d9e6c16c26e9cc278844c0a32403b63c24806688cd149b5804a439f08ce1dbfb1c477f5a740b25b3f9e5882f74bda7898dbcfc4b89c4a937e3aca2104883f1383011cb8e839cb05251c481e265cb01dcc8bf08b1f58d528a9b105db958997217a91142893a26f9c3dd3f8f806e4c02bda5f50eb84aa6ad64973d0e299306f6a317414437f6b7fefd36c32b3c27f0f456b9fadd20b7ae035b169b2b1b4d131e80150c95a2b69def1d7198ba6e49b0edd646f1c4991d3b7f5b8cab56fc931a2d2558ba33f91902686fd6a6eda2fb9cab545cb2b61558e14712e29f912a6ba2437148aea17f6669a9eeff94c9b079ab2dc9266b751471d980ba808ebf77eeed09de300684a1b7ad9ffb2f2854d09583b1c10f041208c8725ea0fea98181bca26bce1aae67e08e8309d360ed72693deec0de26aeb08ee5dc53e2bae44081971999f5a07f34a2ffdca6cf75a110d4f56d4f507b04dcaedaf2133ac97bb4a6e31197cc7dce8c9d0ddc16a996258f2249aa03ae52ffa63f27119dd4ac295b267305a38204fbb96bb21d0120fc4b2963c02f8752189c8b67f827ca38dccaa97d49faeafb1fb964e730d6153f50946e9f4762c36a8a3d12feac413b6bdc744a7f7f6e03d5b711694243d45111a4cd0028761f7712e833f92b10431ddd0002ba55c6e953d68954c5bd0bf5e561fc261b0684d661d1d58f0a008a52496f3a30a8e85c562aa625d2adf47e3cb2079d0e374a39630421b9ef55fc28944b9f753c214e03a59f890478a48a6aca115bc5607551f1d88578f4bdbb3f3bad8efa27c0c540f832a252c07edb21c9b7477249969a0ea73acffdaf03e1595a3923de5a963cc5bee0f5c75b7f54bf4ef1c18a833f81e1194cece226633dc1521c627078b770003791a6e5043a2c105dfff2c4a483ad7cabb1a9f3249f9796db9c7a4e1f1d3cdc107eac1165604a6e443d557d187ff68de9008a0e0b832cb99d708ab0728e107")] }, error: Response(electrum1.cipig.net:20008, Object({"code": Number(1), "message": String("the transaction was rejected by network rules.\n\n\n[0400008085202f89000283aa22dd0800000017a91438b6fd31949ceef35e9ab3d8c25ec5755603e3ae8700000000000000006e6a4c6b6304381d9c67b17521020610f02dfb60f513b41b36221eb0b5c87377f0d48f6ed517848c7c2a793a40c0ac6782012088a914d31a8da756208b326a8294f90f8474f73d210da288210258a9e9b3332e186457ab8d91852fadb2f7bd9dd4d53f6813e5172ce8ec4f3c9cac6800000000b12732006bae22dd0800000001476c2687d8429860995e5ffee5b2c33b4e7de524ad686560599e787d4bc2d52c559d26f60c74a6696255d4bb69374e7234eae0d4ca337d34511b71e2f8d3e2178339f7d89effb8e07c088d9f59720370cff344fd1e995d6bcee157df4c4e19d6f4a8addde098cf8510dba764fec23959f7ede601ee64bb292c120fc2ccbe42dda669c33e817b1a5a0e6c467cf9262b92b39dc2efe62838d36553207b1e5f211cea05c662326b260291de0da2477a544a988f434504438e291c7a74f3219a04c52221626f89655745d2a6b1bff59307ff40b859413cc98be7c461f48b6c6e06150609f73420e1b34eda8d94e68df518ceff18c3d5e5998f31862632519ad4ea8594364d51c9c36b1ae841c591f7dbfa85947534056f176fe65c4086774840fbde80fe0643ec6325bd51f34a0c17ee01202398f5d3d214fe58d32eab90f96b80b1b4dc3de9ae93968a0eaea8f99d0da8a9fc9f9562f6442ca309af12914e244e3fc027243724e3be3baa08ecc8e8ad18707d54b4cd2380d590804456bff023830102352ac2546581ce8a0177ecd4de639f8bdd699bc977b664ab131ca6ee7f4c0866d6ec4e97799523eac8ceeeccd7f497abb590fceeb598e5f3166effdba72b874fd12b942827a91cf5c678a884ced816a779930cc009301098f07a972d86497958111d960175eaa25dc367107906fc15638aa503c870173cbe0ff862028ef31a0e976c4e72d55dc83eadf7504425619061e8b2f671acf84b4218a0874e5221f3fec84ce350db5f26621b65522dee3c14fb7f1014da99d38bd31687e6df65f09641d84c656be94d3c250ee1d875e6a972bc8748ae0d695b911e4a865050c12fae8a4802f410b8e65627d94f917a586dd87fb89a022ff16434100d997a6539e38f57d2cbc2c04ec9abfc51640d7257c1aa7b230648a91f116c23a996eb54453ae42f5cf074459f1a0086cb479f65f4b00b0c2c652ea508cb73ac553727dd726503666911da15dbb4abb614b2aa498473bf5cdc4481e045816dea13d79ce8f114262d50c1965f02a48a22bf5c46f6aa1a924e997858e8ede13a250a5b47cfee9d16e8617f5c356bf46fdfd1b7af1efe741f1325d485cf3e0a7c9d83c05f632e206d8fc7b28ad8c51a5602909e93a595b8932e40d593380143a2fce9be448bbd5e242d24748bad18ba2fdf48369c023b3ac0b0091e47d7245e6420beaee67d047e00bcb1f6426e28912cfd2042fe1e60f61a6ffed2c4d7a244c18d9202a9abb40954b15e29920431438b7e3ac298a8a6e701631397be6b1bd821c7b78251758f781b4cd37128e30ab0ac562d10160385eb40ba7efaf873911bcc2e34e2f12e71ee31a0ca3ec5fbe52369c7bc8aeade98ecd08d04d90fd3fd3d96d7633cb01433eae6b81a69965493518d4586d67e644a7aff39a7766eb8d90a353de0b429f4f3b8aa8ed78d9d82991d73ebf671df521afe529d0c350294af155c7dbda040cb5b45aaf2278316b8cec7781b9c449e6daec29460dcc967dd1c81047238fd5032a6dab0fc2fbde772062820386d842c81b1760c2fe566e587011e69be3cd548f3b82500d753b8e943b17ce8db2eda8560adbf2ceaba836f95a0b0adb56c456b098f29fcb90f4d68b4d7c3fb6afe6e34dc2d9cdacb0ec71c76f5efb1fe957505ab697715eeb5f5c85aa6a7ccad06fdee0427c00d21d5eb98c40e89f953e28758255559301af9ed85da232290c0f9a69d112edc5c315fc10a1f015d229be3abb4a82b6893ef35ff56993f243656001b366900ce7077160a21feb91201a4c2371286f4c64079eb6e6661b28a1c6f46cd2698b99265b7e24309510b452084dd4c34d043413a3948bea0e57b8acdcb9d32b85424e0b1eabf04c06a9ba6273107a01a074728211b3ecd80a90abe3d022ae0344e99aeb52c0eb9eb12ee56968c3c4425ed81cc997161ca0574b935c2c567fc37ed3ca9f65962c09104b9ea330f91dac32f69f0246a7b51b877ef9b60556dd19f61420c5d7ab04889bbc8743bfc04737b9a3628bfbbded722ae7ee08a48fda4c962e06a13867ccfd715f7dc7470958bd9cd12a6119420cdaba817d776736cf0429600abc4df8ceb9d7598c6ed1460f6b88a65359d3a37b866aaba9d6d3fdef612af0d104b0c97e24a8c0e0ac133cb120def1665f0504358fe9bc096587d817ec1b2c21365a092d9f2be9948a27096ba54d57a307048b35337f2d557a9ecd40202acafa5e754c5495cb312be2b6a44e34b95dba6cf8022a89f871ec62ff34c37d16aecc29211188f25c5d309266ba71bcb506b71506bbcaa68e14a3e9f3e5f93bbf20a4d9e6c16c26e9cc278844c0a32403b63c24806688cd149b5804a439f08ce1dbfb1c477f5a740b25b3f9e5882f74bda7898dbcfc4b89c4a937e3aca2104883f1383011cb8e839cb05251c481e265cb01dcc8bf08b1f58d528a9b105db958997217a91142893a26f9c3dd3f8f806e4c02bda5f50eb84aa6ad64973d0e299306f6a317414437f6b7fefd36c32b3c27f0f456b9fadd20b7ae035b169b2b1b4d131e80150c95a2b69def1d7198ba6e49b0edd646f1c4991d3b7f5b8cab56fc931a2d2558ba33f91902686fd6a6eda2fb9cab545cb2b61558e14712e29f912a6ba2437148aea17f6669a9eeff94c9b079ab2dc9266b751471d980ba808ebf77eeed09de300684a1b7ad9ffb2f2854d09583b1c10f041208c8725ea0fea98181bca26bce1aae67e08e8309d360ed72693deec0de26aeb08ee5dc53e2bae44081971999f5a07f34a2ffdca6cf75a110d4f56d4f507b04dcaedaf2133ac97bb4a6e31197cc7dce8c9d0ddc16a996258f2249aa03ae52ffa63f27119dd4ac295b267305a38204fbb96bb21d0120fc4b2963c02f8752189c8b67f827ca38dccaa97d49faeafb1fb964e730d6153f50946e9f4762c36a8a3d12feac413b6bdc744a7f7f6e03d5b711694243d45111a4cd0028761f7712e833f92b10431ddd0002ba55c6e953d68954c5bd0bf5e561fc261b0684d661d1d58f0a008a52496f3a30a8e85c562aa625d2adf47e3cb2079d0e374a39630421b9ef55fc28944b9f753c214e03a59f890478a48a6aca115bc5607551f1d88578f4bdbb3f3bad8efa27c0c540f832a252c07edb21c9b7477249969a0ea73acffdaf03e1595a3923de5a963cc5bee0f5c75b7f54bf4ef1c18a833f81e1194cece226633dc1521c627078b770003791a6e5043a2c105dfff2c4a483ad7cabb1a9f3249f9796db9c7a4e1f1d3cdc107eac1165604a6e443d557d187ff68de9008a0e0b832cb99d708ab0728e107]")})) }))

the transaction was rejected by network rules likely because the change from takerfee was not confirmed when takerpayment was sent this is known behavior though, it was like that all the time

Jan 30 '25 16:01 cipig

second swap with https://sdk.devbuilds.komodo.earth/fix-arrr-note-saving/mm2_13d1dd4-linux-x86-64.zip worked fine

Jan 30 '25 17:01 cipig

second swap with https://sdk.devbuilds.komodo.earth/fix-arrr-note-saving/mm2_13d1dd4-linux-x86-64.zip worked fine

thanks, does this fix the original issue?

Jan 30 '25 18:01 borngraced

thanks, does this fix the original issue?

yes, the last commits fixed the issue https://github.com/KomodoPlatform/komodo-defi-framework/pull/2331#issuecomment-2621793194

Jan 30 '25 19:01 cipig

ARRR change from swaps is not added back to balance only restart fixes ARRR balance waiting for a fix

Feb 03 '25 07:02 cipig

ARRR change from swaps is not added back to balance only restart fixes ARRR balance waiting for a fix

Let's try the latest build again https://github.com/KomodoPlatform/komodo-defi-framework/pull/2331/commits/9a76c1b5ca1ba19a29f7b4401e653a28781a5d0c

Please provide the log file as well. thanks

Feb 03 '25 09:02 borngraced

Let's try the latest build again 9a76c1b

Please provide the log file as well. thanks

I did a ARRR swap, selling 22 ARRR

ARRR balance before the swap was 15762.45617603 ARRR balance after the swap was 15623.96514865 (so there are some ARRR missing) ARRR balance after restart of app went back to 15740.43067341 (which is correct)

The log: 2025-02-03-13-57-34.kdf.log

Feb 03 '25 14:02 cipig

In this PR zhtlc-native-tests now work (as in the current dev branch some fail). But I had to add flavor = "multi_thread" to the zombie_coin_send_dex_fee test. (W/o the 'multi_thread' option an error appeared:

thread 'z_coin::z_coin_native_tests::zombie_coin_send_dex_fee' panicked at 'can call blocking only when running on the multi-threaded runtime', /home/ubuntu/.cargo/git/checkouts/librustzcash-068ee532cb234fc6/4e030a0/zcash_client_sqlite/src/for_async/mod.rs:347:9

Could this error be an issue in a non-test environment?)

Feb 05 '25 09:02 dimxy

I believe you want to change the function to async and remove the usage of block_on and await instead @dimxy

#[tokio::test]

Feb 05 '25 09:02 borngraced

I believe you want to change the function to async and remove the usage of block_on and await instead @dimxy
#[tokio::test]

Yes I am aware of that (used this option is my PR #2112 months ago), so I ran the test already with [token::test] and 'block_on' replaced on 'await' and was receiving this error.

I ran more tests in the zhtlc-native-tests mod with the ZOMBIE chain. 4 of them failed with different errors (at least in my env).

Feb 05 '25 13:02 dimxy

I've not been able to get a swap completed to test this, possibly due to the errors seen in logs below:

10 06:47:50, mm2_main::rpc::dispatcher:125] ERROR RPC error response: z_coin:700] z_tx_history:232] Invalid column type Null at index: 2, name: block
[14:47:50] [error] [kdf.service.cpp:1541] [1409535]: error answer for tx or my_balance: {
    "error": "Invalid column type Null at index: 2, name: block",
    "error_data": "Invalid column type Null at index: 2, name: block",
    "error_path": "z_coin.z_tx_history",
    "error_trace": "z_coin:700] z_tx_history:232]",
    "error_type": "StorageError",
    "id": 42,
    "mmrpc": "2.0"
}

...
10 06:46:55, mm2_main::lp_network:169] ERROR lp_swap:351] Couldn't deserialize swap msg to either 'SwapMsg': data did not match any variant of untagged enum NegotiationDataMsg or to 'SwapStatus': expected value at line 1 column 1

All attempts fail on negotiation with a timeout.

Feb 10 '25 06:02 smk762

I've not been able to get a swap completed to test this

I now have the same problem. All swaps, also non-ARRR swaps fail on negotiation with timeout, eg:

      {
         "event" : {
            "data" : {
               "error" : "maker_swap:610] \"lp_swap:416] Timeout (181 > 180)\""
            },
            "type" : "NegotiateFailed"
         },
         "timestamp" : 1739194610665
      },
      {
         "event" : {
            "type" : "Finished"
         },
         "timestamp" : 1739194610666
      }

Must be one of the latest commits...

found same error in logs: 10 14:40:39, mm2_main::lp_network:169] ERROR lp_swap:350] Couldn't deserialize swap msg to either 'SwapMsg': data did not match any variant of untagged enum NegotiationDataMsg or to 'SwapStatus': expected value at line 1 column 1

Feb 10 '25 14:02 cipig

ok, i have the same problem with latest mm2 from dev branch so problem is not from this PR, but from dev branch

Feb 10 '25 14:02 cipig

@cipig do all nodes used in this swap use latest dev?

Feb 10 '25 15:02 shamardy

@cipig @smk this PR https://github.com/KomodoPlatform/komodo-defi-framework/pull/2353 should fix the issue

Feb 11 '25 15:02 shamardy

@smk762 @cipig this can be tested again and spendable & unspendable balance will persist on restart while fixing the main issue, Take Payment failed due to change from unconfirmed Taker Fee

Feb 13 '25 12:02 borngraced

weird, i started a ARRR swap and it failed on TakerPaymentTransactionFailed:

taker_swap:1719] mm2src/coins/z_coin.rs:1354] mod:717] client:885] Rpc(ResponseParseError(JsonRpcError { client_info: "coin: ARRR", request: JsonRpcRequest { jsonrpc: "2.0", id: 900, method: "blockchain.transaction.broadcast", params: [String("0400008085202f890002c3046b9d0900000017a9146b78e41ad9b5bc1753c91f4778f41989ad73c9558700000000000000006e6a4c6b6304d1eaaf67b17521032b77578065167e141ddb3267e08dfcc29e97de8dbbdd1ee8b5624dd4911528beac6782012088a9149cbcc3219845c7ca68fcde4476c9324210124af3882103aee6dac5bbeacb92ff601568320cb6473d245cfa1c1837eefa2e4620b5729446ac6800000000df7b3200ab086b9d09000000024ed48e56d4772fa6499d4f81f76615ecf10d64a4e3d399fee46d1b39f3dd622739b314aa56fe8ff6f7e704b53d05c17eca3dc01843d70ad33238f8d04bafbd1957acd77c34ebc4306e8d62b1f91e179b16936a684c19f87d116caeeace7df32e3a2bbbf123406ccc567fc2045b48699d5cd543658161d016c02e892a26b49b82923bf75a1fac4b8bd3f581e599df2e6757e4e154303973691f845f959aefddb30a8a9876480adffa92401a65c245b9d9b21370bec4d7531fd2db2f6607d8e90ad8a8521302aab9e7b80b410258e04055232a0e3c2958570ad6fb93dd8ba3725b111dacfc2f7f43069ec1e9a5005fadcdcced0eba6988d15f259bad9f30852e6bf4aef4ccfb4000dd82cd6795c932dc26a48fc521f8a2767d5b6ab4fae1dc0dc57141b94f9d65fe4beb7d8ac49b512d80296e2281fc988c83009efa143c7f891815c6d0c0b16316f0bc68e82f1cad69c7e1bb3837f0116bfc060815104b9b80ca7360cade968fcf3e11556043b607836f1aa18ed2779f40cc820668aff35cac021780d304135d19a4f2e6e8a00e9f1c71043f5972fcd07274ee7d07a7efdb83b839b314aa56fe8ff6f7e704b53d05c17eca3dc01843d70ad33238f8d04bafbd19726983ca6265fbbac5c21ab6bc2869c12b7f7ce66cedd7ecf5907baaf8feb55872fe35c2470791d941389d6f89d55eb2bb74cac85806ea44847c2574c1f13fa2980968146ccb387616a0d95244d6858189960f8a3999582452dfdef94a990095630f0f0e23fcb607ea23733deb67a1dd94d68f78b1c5653d3459aa1c5d905266dd9635306dddae6a4d773963436819f62e505f3f1c5f1712b0d97d8ed02eee7b030a878ad4fa67ac3b63118a313d1bb169a473e4760acdcca6a865aa377969f111463646b797fe155abfbb628c9f78239547b200a8da5f95455ff7363b433699d39bc27beb123a1306f87534ad933a268c0d39cfa0d81303aa0fd0f24f5e44b978fd0d9d9efffc3a297b007bbbf426232da3e3228e1c17a8e503e339f17818e8ced2422e49e319e2ffc42c8e078d246e6858a8eca350e10b4e71afd901fc7c0d021c4562eb994bdcd4a41e8757ae8e56f8423fbe4a1837bbbd36f65d9b6b0f62a5a0c90bd7387b6a63ea1998168c1eb8e8fee492301fce04d7352f90dfbe49164ec65d70037e4ae47535b5d46eee286541ad8afa0bbf8be3d82ac4ff9cf9d5b29be86dfdd59ad8f46a9e58320befd12f64ba886e933e06a2c2fbc16a0b46e8110ee96bbd8a1c0c3a79a5b6b90da358132bb4cc3a3c32ecebc5b68713ea622a808ab5f38b6e2c61fcb8ed6dafc4f01a3b2dde0a03ddb14281d515020431fb266439bc7eaf89af352624c72beca6696818aa96ce86851f47c2a8b389efa2f98ada8904367a761ce8b654b5ddb297a7d3e5e8d3b99b06da38872bf264381d55e436c399c7998e56a6866564100624e9a27a42949c34a7fea05efab2e0e4b06ce3f12d53a2a0a4eba9ef53255efb4fe3d8ec28b3947544ecb142ac143235d1e658e45a7787aee707a6e8986b768c69b9585dbab7569080a4f8bff62fa2a1bee8e8017adc94616ba95a873351e5ecdc0310a54c0d9f95a1aba6150bf7e933e9c31117a913e3cc59cc3d714191518650beb0c2469e7328d67ecc3b38d2bdd6253064d0ae11c7a85653a62ed2a685e9f4654afcdc6d04275a8b239e0e0c13faeda46464ae51e33239602ee5bccc8690a3913449fb427eadeeffadfc2d0aa7a4fd47deffc5ea9b7f9aab0edda69eb1140a5a7943ece33129690bdbdaab73e1d9075bf3a61e32aae1f6a21c9762a61ab380a4294fcefec202468b2aeb3d60a7d321fc7d8e2eda06bde6831802ab1afb74a55bc77e978a34437dc7fc51027cce55a85326f8e02eaf4281dba94ad422f7ec42f0d29f7427787eb1f105917c72af5a0e79c4575bf4d61ac853c5d76d3a27385cf30437f92433dee217dd5a638f021af222c70bcc6b37138c1f21b62a93130f400f109a9edc962230740887dc895e545ba616ffcc6d21173a3b76240eb3a7de9c30387732e85a9bc117df290021fb7b3a18e631fcc88d8cc4bee58513127f5b8c026dc88718cf54970dd84deb3ce944ef7e72d6e76693d0a64804d246eb3fa3ad2fbfeea33a5423bf8bd2d9e269b64f32934f214efdc924ccf2a0710357fa472348c5ce31dc57a61a24674bbe9fac0003e3c94121d721c4b796ac6d585ebf627ab88281ed705c4b85895b6c838b62f1f8028b3cf0884968f54e111d9b057cae2f5e5a4a78e10e5c2b0684998c61a27da17bddc86018a2c25aa901ed9270787195cd677134f8ac9cb56dd42b168cf58128a845f711d7177dfe846630599091812f2fa2034dd80e700d268d6e4115da116cbd2d846c04b28208480d50a68f1521ed2a01252e13cb0c6944223160b3a39bb92dc54188d6893b1bc3f743a5499697e398da844b761bab9b40da3fed4386df790dcc9bd4697b9c0785fdd5141e270afb61cb87f4f74050647132591583bc6f7c6dd4a666137db2478bcf23d78932015d0d74a9550af35d029a9e5fc874bd7bf04695b6a6f800b233dab47349729e19ada8ffe7aa19814370149ec38d81a949a340cc9b109751b50f80a744617819e7a2149ad25ddc84f1c27165ac0379e3065d6ce150ab1ae6188b69ee3dc7534843780f56cd1c11e9795b0449e3e92d404c364bec10d9e7ea5fb87abe4c9674d5afc9ae2524fc8f84ad21ce57bad8b05cc2a60b98c4053a0df2aa7542964e65e83bd58581634723287d9d7d7f7664350b4976affa728962678612032f8fdb7ad947b1ad720ce754ded5305b2bdd8ec641ad36a99bdb1730b8100277a483b25b7b715063d5d30f1f0bb014fedc4907f2e14c2b13edec01233a080f2d914434c5d190845c17dcdeccfc2292158dc706a84d01dedbfb66ce469214b0c80272bff2d8854ca4780976d2b2ae424e1ea6ca45ba70e0a4a2a7795db13e7330c2d54cc0e6d44cefa839c9d22b8470a52d5b2b438f4813aaf99b562b46c1b74490540bd72928549b70392829e5615f767f6d4cb1c7fbdf4cbf3434703bd49ca028d84f40e3820620468b1922ca41f7dc47cf1666c62693f7011f8520ffeaf8746cf8c90cb3ba76e252e22142d8c08126a3e9817008ad1e8d1584a93be942f079b4ada04cae8f8f01066a4da0f968c008427f74c700a8729e0068c69dc726076933b10b99668015eaad63ba74636540bfb1cc65e7eb71aae2f8da58936045c8c4d290dd2cd83534227770175e2396df064a044de57472210c289b74c2429df2757ba4d1105dbd33ed82ba2c32e1625bdb6b423cc124e18748a7684b72cc47cf8a2748d997d90ca5a58cbdf3a6bac786f27d5e65d31eca482670b6633d8038cb04cdc610a3e19ec448d8ba0bd910bda34d45b648f06a1f3edfc7db38be2c9d252f2c48138573b8c75bea6d0b94560b4cf99fdbf8a42488100bbb374def114c858877773b8d4b63cee0de8524b8af5a3032cfef5a998797a8c031d8770666d98fd56440149d15da9fe64aa044d39bf384e56e2bee977fb538c1eaabd6d1a183863c41d33ad78659ffe6bab06bb034d3ae6b24730e5f1a813fadcdb2cffe2fc3532ba9c48f11534a6ae105f2ed21c378bedee3a4665912f9e515226495ef7e0a266f729f5c715c91747a2453dc2c3ac2053220c640872a8a95e2a57f26aa99bbcc781eb871390e373a83a8607dd3da5b73794b2333ccc999e5fce992d83aa71ef7f7bf8734006508be2dfa4e910966bfb1513faac64bc2c8482b24253313ba746c9f1a329b50da4cf07198a7661294963270aaf1ed8f40f912f241e6cb312c44bfc3437f0c08")] }, error: Response(electrum1.cipig.net:20008, Object({"code": Number(1), "message": String("the transaction was rejected by network rules.\n\n\n[0400008085202f890002c3046b9d0900000017a9146b78e41ad9b5bc1753c91f4778f41989ad73c9558700000000000000006e6a4c6b6304d1eaaf67b17521032b77578065167e141ddb3267e08dfcc29e97de8dbbdd1ee8b5624dd4911528beac6782012088a9149cbcc3219845c7ca68fcde4476c9324210124af3882103aee6dac5bbeacb92ff601568320cb6473d245cfa1c1837eefa2e4620b5729446ac6800000000df7b3200ab086b9d09000000024ed48e56d4772fa6499d4f81f76615ecf10d64a4e3d399fee46d1b39f3dd622739b314aa56fe8ff6f7e704b53d05c17eca3dc01843d70ad33238f8d04bafbd1957acd77c34ebc4306e8d62b1f91e179b16936a684c19f87d116caeeace7df32e3a2bbbf123406ccc567fc2045b48699d5cd543658161d016c02e892a26b49b82923bf75a1fac4b8bd3f581e599df2e6757e4e154303973691f845f959aefddb30a8a9876480adffa92401a65c245b9d9b21370bec4d7531fd2db2f6607d8e90ad8a8521302aab9e7b80b410258e04055232a0e3c2958570ad6fb93dd8ba3725b111dacfc2f7f43069ec1e9a5005fadcdcced0eba6988d15f259bad9f30852e6bf4aef4ccfb4000dd82cd6795c932dc26a48fc521f8a2767d5b6ab4fae1dc0dc57141b94f9d65fe4beb7d8ac49b512d80296e2281fc988c83009efa143c7f891815c6d0c0b16316f0bc68e82f1cad69c7e1bb3837f0116bfc060815104b9b80ca7360cade968fcf3e11556043b607836f1aa18ed2779f40cc820668aff35cac021780d304135d19a4f2e6e8a00e9f1c71043f5972fcd07274ee7d07a7efdb83b839b314aa56fe8ff6f7e704b53d05c17eca3dc01843d70ad33238f8d04bafbd19726983ca6265fbbac5c21ab6bc2869c12b7f7ce66cedd7ecf5907baaf8feb55872fe35c2470791d941389d6f89d55eb2bb74cac85806ea44847c2574c1f13fa2980968146ccb387616a0d95244d6858189960f8a3999582452dfdef94a990095630f0f0e23fcb607ea23733deb67a1dd94d68f78b1c5653d3459aa1c5d905266dd9635306dddae6a4d773963436819f62e505f3f1c5f1712b0d97d8ed02eee7b030a878ad4fa67ac3b63118a313d1bb169a473e4760acdcca6a865aa377969f111463646b797fe155abfbb628c9f78239547b200a8da5f95455ff7363b433699d39bc27beb123a1306f87534ad933a268c0d39cfa0d81303aa0fd0f24f5e44b978fd0d9d9efffc3a297b007bbbf426232da3e3228e1c17a8e503e339f17818e8ced2422e49e319e2ffc42c8e078d246e6858a8eca350e10b4e71afd901fc7c0d021c4562eb994bdcd4a41e8757ae8e56f8423fbe4a1837bbbd36f65d9b6b0f62a5a0c90bd7387b6a63ea1998168c1eb8e8fee492301fce04d7352f90dfbe49164ec65d70037e4ae47535b5d46eee286541ad8afa0bbf8be3d82ac4ff9cf9d5b29be86dfdd59ad8f46a9e58320befd12f64ba886e933e06a2c2fbc16a0b46e8110ee96bbd8a1c0c3a79a5b6b90da358132bb4cc3a3c32ecebc5b68713ea622a808ab5f38b6e2c61fcb8ed6dafc4f01a3b2dde0a03ddb14281d515020431fb266439bc7eaf89af352624c72beca6696818aa96ce86851f47c2a8b389efa2f98ada8904367a761ce8b654b5ddb297a7d3e5e8d3b99b06da38872bf264381d55e436c399c7998e56a6866564100624e9a27a42949c34a7fea05efab2e0e4b06ce3f12d53a2a0a4eba9ef53255efb4fe3d8ec28b3947544ecb142ac143235d1e658e45a7787aee707a6e8986b768c69b9585dbab7569080a4f8bff62fa2a1bee8e8017adc94616ba95a873351e5ecdc0310a54c0d9f95a1aba6150bf7e933e9c31117a913e3cc59cc3d714191518650beb0c2469e7328d67ecc3b38d2bdd6253064d0ae11c7a85653a62ed2a685e9f4654afcdc6d04275a8b239e0e0c13faeda46464ae51e33239602ee5bccc8690a3913449fb427eadeeffadfc2d0aa7a4fd47deffc5ea9b7f9aab0edda69eb1140a5a7943ece33129690bdbdaab73e1d9075bf3a61e32aae1f6a21c9762a61ab380a4294fcefec202468b2aeb3d60a7d321fc7d8e2eda06bde6831802ab1afb74a55bc77e978a34437dc7fc51027cce55a85326f8e02eaf4281dba94ad422f7ec42f0d29f7427787eb1f105917c72af5a0e79c4575bf4d61ac853c5d76d3a27385cf30437f92433dee217dd5a638f021af222c70bcc6b37138c1f21b62a93130f400f109a9edc962230740887dc895e545ba616ffcc6d21173a3b76240eb3a7de9c30387732e85a9bc117df290021fb7b3a18e631fcc88d8cc4bee58513127f5b8c026dc88718cf54970dd84deb3ce944ef7e72d6e76693d0a64804d246eb3fa3ad2fbfeea33a5423bf8bd2d9e269b64f32934f214efdc924ccf2a0710357fa472348c5ce31dc57a61a24674bbe9fac0003e3c94121d721c4b796ac6d585ebf627ab88281ed705c4b85895b6c838b62f1f8028b3cf0884968f54e111d9b057cae2f5e5a4a78e10e5c2b0684998c61a27da17bddc86018a2c25aa901ed9270787195cd677134f8ac9cb56dd42b168cf58128a845f711d7177dfe846630599091812f2fa2034dd80e700d268d6e4115da116cbd2d846c04b28208480d50a68f1521ed2a01252e13cb0c6944223160b3a39bb92dc54188d6893b1bc3f743a5499697e398da844b761bab9b40da3fed4386df790dcc9bd4697b9c0785fdd5141e270afb61cb87f4f74050647132591583bc6f7c6dd4a666137db2478bcf23d78932015d0d74a9550af35d029a9e5fc874bd7bf04695b6a6f800b233dab47349729e19ada8ffe7aa19814370149ec38d81a949a340cc9b109751b50f80a744617819e7a2149ad25ddc84f1c27165ac0379e3065d6ce150ab1ae6188b69ee3dc7534843780f56cd1c11e9795b0449e3e92d404c364bec10d9e7ea5fb87abe4c9674d5afc9ae2524fc8f84ad21ce57bad8b05cc2a60b98c4053a0df2aa7542964e65e83bd58581634723287d9d7d7f7664350b4976affa728962678612032f8fdb7ad947b1ad720ce754ded5305b2bdd8ec641ad36a99bdb1730b8100277a483b25b7b715063d5d30f1f0bb014fedc4907f2e14c2b13edec01233a080f2d914434c5d190845c17dcdeccfc2292158dc706a84d01dedbfb66ce469214b0c80272bff2d8854ca4780976d2b2ae424e1ea6ca45ba70e0a4a2a7795db13e7330c2d54cc0e6d44cefa839c9d22b8470a52d5b2b438f4813aaf99b562b46c1b74490540bd72928549b70392829e5615f767f6d4cb1c7fbdf4cbf3434703bd49ca028d84f40e3820620468b1922ca41f7dc47cf1666c62693f7011f8520ffeaf8746cf8c90cb3ba76e252e22142d8c08126a3e9817008ad1e8d1584a93be942f079b4ada04cae8f8f01066a4da0f968c008427f74c700a8729e0068c69dc726076933b10b99668015eaad63ba74636540bfb1cc65e7eb71aae2f8da58936045c8c4d290dd2cd83534227770175e2396df064a044de57472210c289b74c2429df2757ba4d1105dbd33ed82ba2c32e1625bdb6b423cc124e18748a7684b72cc47cf8a2748d997d90ca5a58cbdf3a6bac786f27d5e65d31eca482670b6633d8038cb04cdc610a3e19ec448d8ba0bd910bda34d45b648f06a1f3edfc7db38be2c9d252f2c48138573b8c75bea6d0b94560b4cf99fdbf8a42488100bbb374def114c858877773b8d4b63cee0de8524b8af5a3032cfef5a998797a8c031d8770666d98fd56440149d15da9fe64aa044d39bf384e56e2bee977fb538c1eaabd6d1a183863c41d33ad78659ffe6bab06bb034d3ae6b24730e5f1a813fadcdb2cffe2fc3532ba9c48f11534a6ae105f2ed21c378bedee3a4665912f9e515226495ef7e0a266f729f5c715c91747a2453dc2c3ac2053220c640872a8a95e2a57f26aa99bbcc781eb871390e373a83a8607dd3da5b73794b2333ccc999e5fce992d83aa71ef7f7bf8734006508be2dfa4e910966bfb1513faac64bc2c8482b24253313ba746c9f1a329b50da4cf07198a7661294963270aaf1ed8f40f912f241e6cb312c44bfc3437f0c08]")})) }))

"the transaction was rejected by network rules"

both maker and taker were using e4e6114

Feb 14 '25 16:02 cipig

was anything changed in the last commits? tried another ARRR swap and it also failed:

15 14:16:52, mm2_main::lp_swap::taker_swap:1345] INFO Taker fee tx hash 9bacb8aee6a22de81a85feeded7b7086b092402f4d63f81f2df41f07ac54c8f7
15 14:16:52, coins::z_coin::z_rpc:889] INFO (Re)starting light_wallet_db_sync_loop for ARRR, blocks per iteration 5000, interval in ms 0
15 14:16:54, mm2_main::lp_swap::taker_swap:1429] INFO Got maker payment 95742aa4547d16ac55a63df97b5a29551e873b420dfa963ee08719109ff369ac
15 14:16:54, mm2_main::lp_swap::taker_swap:1442] INFO Before wait confirm
15 14:17:40, mm2_main::lp_swap::taker_swap:1460] INFO After wait confirm
15 14:17:52, coins::z_coin::z_rpc:889] INFO (Re)starting light_wallet_db_sync_loop for ARRR, blocks per iteration 5000, interval in ms 0
15 14:17:52, mm2_main::lp_swap::taker_swap:506] ERROR [swap uuid=b7016733-639a-43b9-8dd0-9b7b11f8a6a3] TakerPaymentTransactionFailed(SwapError { error: "taker_swap:1719] mm2src/coins/z_coin.rs:1354] mod:717] client:885] Rpc(ResponseParseError(JsonRpcError { client_info: \"coin: ARRR\", request: JsonRpcRequest { jsonrpc: \"2.0\", id: 194, method: \"blockchain.transaction.broadcast\", params: [String(\"0400008085202f8900022b1e937c0900000017a91452f43fbc4a6ab648d00297ef8ef05375582671388700000000000000006e6a4c6b6304a41bb167b1752103222bf7304b86d43b0f83dc923af0a819e865f9a2b637b11897149986230dd4acac6782012088a9146f88c3477521f0d594ba23e1bb940cfd5309810188210329aa6b05b766bff89167b707fb52d349ba2889ef085a6e47b237a78fa38f0314ac6800000000e08032001322937c0900000002728f0dfca7abac1f03dd1a7fc4ca8fb8709ad4528bb22bc6b59e370c461ce86a5ef7e2e8c28c637f56ea29599b4c670fdda70d37e2d7caa3bbbe6c571b45615c42ff36bf5dfeaf70984519db1693e4faeaed20bdd77a102cd25a06d8fd5b9d5110d6ffa8a8959f2c396d3e70356aae226e47e5d5d15ba8693d701268efcf4a12af419a826ae55524bd51c057ca753664f6e802da2ed14cc074878bdf740fa95788988aedeedc6d281a859301d91007e7b1bfa890d45588ad8826a0e1212b42e4d4618a4de9848c974c4804d5e6e733bd196c16b92ec36650df38aaa1814128c408736d0b561f9699ff9f3b8eb103727d9a24e4497047c6d7f60b5d3aaa67b97a785169c2be9c8f15e6065f0f350b2a14b3138474d049b56a061681d3a4c5dbbe80f592bf6677a7a7f31146257f38337b11682fe9595e753ae325bcc45b00046dcc1242064ee02becba26a48b10b86438eb5e226b0b8d98c0f7c5f29420685abe9f5a4d126660dcca4033de72110c46ec7f064880643ee6d403d3b7084c895e08fef6522f65c819d0af5029d197abcbf750e032fadb56846843dbebd4a27e118b5ef7e2e8c28c637f56ea29599b4c670fdda70d37e2d7caa3bbbe6c571b45615c726983ca6265fbbac5c21ab6bc2869c12b7f7ce66cedd7ecf5907baaf8feb558fa4683439eef7dea2462f01fef23cdc0a7b7e97b25b071b4c55bc47ccb3373d9b21c4cd5f13401299951b1ead97063745b1902fe7e7c155fe18f530abcd47fd69bb618ffb6534ec36bad332171c2931582bb69765dbafbde839b7274bd7b8d786ac57ab7fa976edc1ff09f9396153fb0c32938aca4b80d95d950444257439f1702ac036d4396f3394fcc3a516ab5d3d8247d4de69c98fbfa845a3d43c7c9694d8cb4bec6870299272f72119321fd75f485ea0d6fb0488bf6a7097f6628a3de725c7e7b2001636fb336da67b83a971abdf568c5c987844846b55a6d390e91e9f5510d98a42986976694300ec9d7e1a58da6e33cc69d2562556adbbcde8ed031557c5fcd9e3d5496ad8682be984f4c821daf10ea5d517537e704bfe8c137232d0b02f3d75fe99e2f2e26436049eb68a46054ba5d0b0b833e196a958501d83b9ca297b181742a12df211ae4f5edb6d837521e33f8a5f23529c52094225e69400a143039b7b939fa42cbcb53fd4e877d717ba3d0aea6ac491784bfe7e5ee761a9ef9a64de988cb94afd9aad57684658466320ea0ec7940914fc6e12ff462cc1a6aeab69fffb45b2cb60f06d2a57363226ddb39530bb945d9012f7c84cb2a01e9084f95efab2eae8cbc954b8d9d94faec45f0ad9829520044441661b6a633533e4c84eee67b83ae20e3fd2cd6bf41d62967c8dd988302293487d7a0af7721dd05c35328dba605a28dfac5c23205ccc6ca148c94e70371a9dbbe127f94e97e13216dbb3e3c82c2aec721e4a4095bad1318a4aee5bd0be99eae6fef65ffede7110de1f5bf17d2c4b935dbe7b3739ed0fffdb72bbb533c64fd881486ec4c38771fabb16b31ed2c7230b9ada0263fbd435562c458be7c790cd1cd73218727b3e03e129554b8ad500e46feebef43db53c1106fa33428c2ee2f380af34bca5dd1843275bb5456a60f51246c0e9acf2327635652910da4b0e1a88a0abef3c328b6b985dcd195d9793414f2c2c4e27625c2cdd70deec681b2055e9a3a861911f3a106dd8cc90baeea8563076fc5e8c5cf49c21da4114e48a0b75cb6b0beb633e354ab9407b8207904e22e5c5c43b7361c12d4785922dd3d455145a2f7da88ebc813e922093a35323af86493535c372645eafb9a2520595a0f1e4b34ace779f5422c28e28b2bfcb93e25efcdfdb534f6006fc42d28a1387aa2b5db6b22214c350267407155d3e51276769a7307993723f5af59013feb389a8378eddf0ff81fc6033add53d122a8d2ee3133c442a2c4785ac091dbcf12c4ef47cf46e51fe26f644b2e9b9048c130ce8de5442cb0b4078068d7accf281a982eead2a7aeab5974264421156e47d07ca683ec5e39a50f27fe36af1efef43346874648ce13dd65c877c68dedc31aeef9f709ae517f046a1c080cd9d6074d2cfdbb6e7c6c5c104cd6d37eb3fb62af2fcee3ad65135a6cc0bffd6cd09c2855785dd79d9a9aa3911d19e0bf9fadd41eebe7daa0798b1a7181352d3cfaaf7a38400a86addc7914127f99a305440bbbfdf15090905ac2c5b6087bb9bd52844ac17e9bad2240d05008f41163b6cd70b406af2b54666e907e1136912772c8bb5c539d95baa924c7300e81d3a4e3d4060541d19913817f31f320f94b12e2ecb0e87f87ee49f97a2ad87653e14608e10fcfccd3dbd1da8b32d7a2ee1c3e597388e73eb463a4279368e7a9cc12988c9bec3641509a2d9e838652e7f58e3bcc2a84d6fe6a0e3220bcef82a6a6589f44dbd62e3e519f3cfb4e59e133918d14b718bc1800e7adaa2dbd7a16c140bc8f6de83814d5280f8fb05126d5af2e484c01a2d1d7bff0310286393a385189bce152bb1895b69488054f05cb955d7c8ca510f016e6a9686f31b0a819614661d3f552ccf365d622854fdfc072dbdb2032923a383b4f0ae90bc50320cd1446b317ca67f588f15de2a30819b2fdba4b2d764339320131c11c36d250a4ea7bd020dda719ae58f5236e2bc26411a3df3cfcc5d1245951ac1bf7cfdb04cb980208a1ad099295d3bd4985e577088d186f85b19a2b4732eeb65757f3dbce18ab8b830326bbf51d17f8e4bd1316fc7d479c865829478d7faba8397cf1300b2ac40311e23c9a85789463728b4ffe468cc9d58923df19203c085e093ca56d58e1675e4e550df13b7ab069fe5ee33e9dce2f9a9251bc390f8849e68c518cbb39012c1c72fb5f7cc164ee601391d2babe4f694d749e533a8289f07f6a6183885fa5f84846d36da6fe026689ba0dabd67604e082bbe3ea70d5a5c551e1bd6a9000b3a1d93e00253523d83639598276d4644e8d2a57b20743778dc5f55f9a32b332772553581ff1eb8bd1abe177cbe1d30cc2ee5b570971a42832b9b3913b465e58d04b6be9314ffec213016e046c76cd889e0c27858963472f926d0cc4c02f39aa249321b81b85b52a6ebcb0a162b93db0b10b7d6688df8135ad747abe78564b1d53377aaa5f0c1ba177ee5be0657d19ae1bb87b18ab37d98bcfdadff1189da83b2f904c4e2d11452e71252a841eb9514c0e8b38300b96fa038ebb012715e4d28d8cf9024f85169cdf1889323b967da43aa577717e863255c28d6e4d84e4069b5aec817ec7b35effa8d9162f03283cb25a2fa4dab47cbbe6ed4057d1f0784447551d7b8a9821d7577e56e49c08c986720848e0bc7787ad17426acd9209b3b8bf127210c38b0498264bcad4d690b85a6346fde6e1d8b1047fcdf3327feb7d769cf7530a3e5bd2cc887316a5d896a25404b47805b4793b8e1faa7c4a45be51af3bb900a5a74e52baf93fc0930736db9de95380c159c68d2af3b2a375ee73596ccf7997b24b5a86b99190b74542fb38da3515dde7c14bf12f8ce5964b217ff72ac3b4fda8cd33995b23b5115a0130dc1ce00155ba264fd54d7d6f0688af7aa60e66a76b68fb12abf21d822d595314676b2f5bf5d2ec0b4b424e05c75dd27d8732759106278efd7f4e114693b97ad0ef0c056f4d2752da54a584b5ee9113842799325cf61cbaaed3f3a88b992c1a0ad2851de7effe035be68f8115c5ae67a4161cda0f257b8247f732633b3ff9312dd88188fa524b03149c0d6900afc5e5f34aa37ea2640467304e6d9160ac19e7ce3c66573ed28ff96d57e25a11631b834f018905f161d5d362273e2d57e5763c6310972adfd888ca46aec12e06\")] }, error: Response(electrum1.cipig.net:20008, Object({\"code\": Number(1), \"message\": String(\"the transaction was rejected by network rules.\\n\\n\\n[0400008085202f8900022b1e937c0900000017a91452f43fbc4a6ab648d00297ef8ef05375582671388700000000000000006e6a4c6b6304a41bb167b1752103222bf7304b86d43b0f83dc923af0a819e865f9a2b637b11897149986230dd4acac6782012088a9146f88c3477521f0d594ba23e1bb940cfd5309810188210329aa6b05b766bff89167b707fb52d349ba2889ef085a6e47b237a78fa38f0314ac6800000000e08032001322937c0900000002728f0dfca7abac1f03dd1a7fc4ca8fb8709ad4528bb22bc6b59e370c461ce86a5ef7e2e8c28c637f56ea29599b4c670fdda70d37e2d7caa3bbbe6c571b45615c42ff36bf5dfeaf70984519db1693e4faeaed20bdd77a102cd25a06d8fd5b9d5110d6ffa8a8959f2c396d3e70356aae226e47e5d5d15ba8693d701268efcf4a12af419a826ae55524bd51c057ca753664f6e802da2ed14cc074878bdf740fa95788988aedeedc6d281a859301d91007e7b1bfa890d45588ad8826a0e1212b42e4d4618a4de9848c974c4804d5e6e733bd196c16b92ec36650df38aaa1814128c408736d0b561f9699ff9f3b8eb103727d9a24e4497047c6d7f60b5d3aaa67b97a785169c2be9c8f15e6065f0f350b2a14b3138474d049b56a061681d3a4c5dbbe80f592bf6677a7a7f31146257f38337b11682fe9595e753ae325bcc45b00046dcc1242064ee02becba26a48b10b86438eb5e226b0b8d98c0f7c5f29420685abe9f5a4d126660dcca4033de72110c46ec7f064880643ee6d403d3b7084c895e08fef6522f65c819d0af5029d197abcbf750e032fadb56846843dbebd4a27e118b5ef7e2e8c28c637f56ea29599b4c670fdda70d37e2d7caa3bbbe6c571b45615c726983ca6265fbbac5c21ab6bc2869c12b7f7ce66cedd7ecf5907baaf8feb558fa4683439eef7dea2462f01fef23cdc0a7b7e97b25b071b4c55bc47ccb3373d9b21c4cd5f13401299951b1ead97063745b1902fe7e7c155fe18f530abcd47fd69bb618ffb6534ec36bad332171c2931582bb69765dbafbde839b7274bd7b8d786ac57ab7fa976edc1ff09f9396153fb0c32938aca4b80d95d950444257439f1702ac036d4396f3394fcc3a516ab5d3d8247d4de69c98fbfa845a3d43c7c9694d8cb4bec6870299272f72119321fd75f485ea0d6fb0488bf6a7097f6628a3de725c7e7b2001636fb336da67b83a971abdf568c5c987844846b55a6d390e91e9f5510d98a42986976694300ec9d7e1a58da6e33cc69d2562556adbbcde8ed031557c5fcd9e3d5496ad8682be984f4c821daf10ea5d517537e704bfe8c137232d0b02f3d75fe99e2f2e26436049eb68a46054ba5d0b0b833e196a958501d83b9ca297b181742a12df211ae4f5edb6d837521e33f8a5f23529c52094225e69400a143039b7b939fa42cbcb53fd4e877d717ba3d0aea6ac491784bfe7e5ee761a9ef9a64de988cb94afd9aad57684658466320ea0ec7940914fc6e12ff462cc1a6aeab69fffb45b2cb60f06d2a57363226ddb39530bb945d9012f7c84cb2a01e9084f95efab2eae8cbc954b8d9d94faec45f0ad9829520044441661b6a633533e4c84eee67b83ae20e3fd2cd6bf41d62967c8dd988302293487d7a0af7721dd05c35328dba605a28dfac5c23205ccc6ca148c94e70371a9dbbe127f94e97e13216dbb3e3c82c2aec721e4a4095bad1318a4aee5bd0be99eae6fef65ffede7110de1f5bf17d2c4b935dbe7b3739ed0fffdb72bbb533c64fd881486ec4c38771fabb16b31ed2c7230b9ada0263fbd435562c458be7c790cd1cd73218727b3e03e129554b8ad500e46feebef43db53c1106fa33428c2ee2f380af34bca5dd1843275bb5456a60f51246c0e9acf2327635652910da4b0e1a88a0abef3c328b6b985dcd195d9793414f2c2c4e27625c2cdd70deec681b2055e9a3a861911f3a106dd8cc90baeea8563076fc5e8c5cf49c21da4114e48a0b75cb6b0beb633e354ab9407b8207904e22e5c5c43b7361c12d4785922dd3d455145a2f7da88ebc813e922093a35323af86493535c372645eafb9a2520595a0f1e4b34ace779f5422c28e28b2bfcb93e25efcdfdb534f6006fc42d28a1387aa2b5db6b22214c350267407155d3e51276769a7307993723f5af59013feb389a8378eddf0ff81fc6033add53d122a8d2ee3133c442a2c4785ac091dbcf12c4ef47cf46e51fe26f644b2e9b9048c130ce8de5442cb0b4078068d7accf281a982eead2a7aeab5974264421156e47d07ca683ec5e39a50f27fe36af1efef43346874648ce13dd65c877c68dedc31aeef9f709ae517f046a1c080cd9d6074d2cfdbb6e7c6c5c104cd6d37eb3fb62af2fcee3ad65135a6cc0bffd6cd09c2855785dd79d9a9aa3911d19e0bf9fadd41eebe7daa0798b1a7181352d3cfaaf7a38400a86addc7914127f99a305440bbbfdf15090905ac2c5b6087bb9bd52844ac17e9bad2240d05008f41163b6cd70b406af2b54666e907e1136912772c8bb5c539d95baa924c7300e81d3a4e3d4060541d19913817f31f320f94b12e2ecb0e87f87ee49f97a2ad87653e14608e10fcfccd3dbd1da8b32d7a2ee1c3e597388e73eb463a4279368e7a9cc12988c9bec3641509a2d9e838652e7f58e3bcc2a84d6fe6a0e3220bcef82a6a6589f44dbd62e3e519f3cfb4e59e133918d14b718bc1800e7adaa2dbd7a16c140bc8f6de83814d5280f8fb05126d5af2e484c01a2d1d7bff0310286393a385189bce152bb1895b69488054f05cb955d7c8ca510f016e6a9686f31b0a819614661d3f552ccf365d622854fdfc072dbdb2032923a383b4f0ae90bc50320cd1446b317ca67f588f15de2a30819b2fdba4b2d764339320131c11c36d250a4ea7bd020dda719ae58f5236e2bc26411a3df3cfcc5d1245951ac1bf7cfdb04cb980208a1ad099295d3bd4985e577088d186f85b19a2b4732eeb65757f3dbce18ab8b830326bbf51d17f8e4bd1316fc7d479c865829478d7faba8397cf1300b2ac40311e23c9a85789463728b4ffe468cc9d58923df19203c085e093ca56d58e1675e4e550df13b7ab069fe5ee33e9dce2f9a9251bc390f8849e68c518cbb39012c1c72fb5f7cc164ee601391d2babe4f694d749e533a8289f07f6a6183885fa5f84846d36da6fe026689ba0dabd67604e082bbe3ea70d5a5c551e1bd6a9000b3a1d93e00253523d83639598276d4644e8d2a57b20743778dc5f55f9a32b332772553581ff1eb8bd1abe177cbe1d30cc2ee5b570971a42832b9b3913b465e58d04b6be9314ffec213016e046c76cd889e0c27858963472f926d0cc4c02f39aa249321b81b85b52a6ebcb0a162b93db0b10b7d6688df8135ad747abe78564b1d53377aaa5f0c1ba177ee5be0657d19ae1bb87b18ab37d98bcfdadff1189da83b2f904c4e2d11452e71252a841eb9514c0e8b38300b96fa038ebb012715e4d28d8cf9024f85169cdf1889323b967da43aa577717e863255c28d6e4d84e4069b5aec817ec7b35effa8d9162f03283cb25a2fa4dab47cbbe6ed4057d1f0784447551d7b8a9821d7577e56e49c08c986720848e0bc7787ad17426acd9209b3b8bf127210c38b0498264bcad4d690b85a6346fde6e1d8b1047fcdf3327feb7d769cf7530a3e5bd2cc887316a5d896a25404b47805b4793b8e1faa7c4a45be51af3bb900a5a74e52baf93fc0930736db9de95380c159c68d2af3b2a375ee73596ccf7997b24b5a86b99190b74542fb38da3515dde7c14bf12f8ce5964b217ff72ac3b4fda8cd33995b23b5115a0130dc1ce00155ba264fd54d7d6f0688af7aa60e66a76b68fb12abf21d822d595314676b2f5bf5d2ec0b4b424e05c75dd27d8732759106278efd7f4e114693b97ad0ef0c056f4d2752da54a584b5ee9113842799325cf61cbaaed3f3a88b992c1a0ad2851de7effe035be68f8115c5ae67a4161cda0f257b8247f732633b3ff9312dd88188fa524b03149c0d6900afc5e5f34aa37ea2640467304e6d9160ac19e7ce3c66573ed28ff96d57e25a11631b834f018905f161d5d362273e2d57e5763c6310972adfd888ca46aec12e06]\")})) }))" })
15 14:17:52, coins::z_coin:1680] INFO [b7016733-639a-43b9-8dd0-9b7b11f8a6a3] Running swap cleanup for ARRR
15 14:17:52, coins::z_coin:1695] INFO Confirming tx "9bacb8aee6a22de81a85feeded7b7086b092402f4d63f81f2df41f07ac54c8f7"
15 14:17:52, coins::utxo::rpc_clients:130] INFO Waiting for tx 9bacb8aee6a22de81a85feeded7b7086b092402f4d63f81f2df41f07ac54c8f7 confirmations, now 0, required 2, requires_notarization true
15 14:18:07, coins::utxo::rpc_clients:130] INFO Waiting for tx 9bacb8aee6a22de81a85feeded7b7086b092402f4d63f81f2df41f07ac54c8f7 confirmations, now 0, required 2, requires_notarization true
15 14:18:22, coins::utxo::rpc_clients:130] INFO Waiting for tx 9bacb8aee6a22de81a85feeded7b7086b092402f4d63f81f2df41f07ac54c8f7 confirmations, now 0, required 2, requires_notarization true
15 14:18:37, coins::utxo::rpc_clients:130] INFO Waiting for tx 9bacb8aee6a22de81a85feeded7b7086b092402f4d63f81f2df41f07ac54c8f7 confirmations, now 1, required 2, requires_notarization true
15 14:18:52, coins::utxo::rpc_clients:130] INFO Waiting for tx 9bacb8aee6a22de81a85feeded7b7086b092402f4d63f81f2df41f07ac54c8f7 confirmations, now 1, required 2, requires_notarization true
15 14:19:07, coins::utxo::rpc_clients:130] INFO Waiting for tx 9bacb8aee6a22de81a85feeded7b7086b092402f4d63f81f2df41f07ac54c8f7 confirmations, now 1, required 2, requires_notarization true
15 14:19:22, coins::utxo::rpc_clients:130] INFO Waiting for tx 9bacb8aee6a22de81a85feeded7b7086b092402f4d63f81f2df41f07ac54c8f7 confirmations, now 1, required 2, requires_notarization true
15 14:19:37, coins::utxo::rpc_clients:130] INFO Waiting for tx 9bacb8aee6a22de81a85feeded7b7086b092402f4d63f81f2df41f07ac54c8f7 confirmations, now 1, required 2, requires_notarization true
15 14:19:52, coins::utxo::rpc_clients:130] INFO Waiting for tx 9bacb8aee6a22de81a85feeded7b7086b092402f4d63f81f2df41f07ac54c8f7 confirmations, now 1, required 2, requires_notarization true
15 14:20:07, coins::utxo::rpc_clients:130] INFO Waiting for tx 9bacb8aee6a22de81a85feeded7b7086b092402f4d63f81f2df41f07ac54c8f7 confirmations, now 1, required 2, requires_notarization true

taker tries to send takerpayment before takerfee is confirmed... idk if takerpayment tried to use change from takerfee, but likely question: is makercoin important? does it make any difference for the swap if it's an EVM token or a UTXO coin?

Feb 15 '25 14:02 cipig

"the transaction was rejected by network rules"

both maker and taker were using e4e6114

the tx has empty vin (I have seen the same issue in zombie tests sometimes)

Feb 17 '25 14:02 dimxy

"the transaction was rejected by network rules" both maker and taker were using e4e6114

the tx has empty vin (I have seen the same issue in zombie tests sometimes)

aha, seems it's not related to this PR.. cc. @dimxy

Feb 17 '25 14:02 borngraced

"the transaction was rejected by network rules" both maker and taker were using e4e6114

the tx has empty vin (I have seen the same issue in zombie tests sometimes)

aha, seems it's not related to this PR.. cc. @dimxy

Ah sorry, shielded spends are present (never mind my note)

Feb 17 '25 15:02 dimxy

the tx has empty vin (I have seen the same issue in zombie tests sometimes)

imagine you have a single ARRR UTXO, then you start a swap, trying to sell some ARRR ARRR takerfee is sent... then ARRR takerpaymet needs to use the change from takerfee... but if takerfee is not confirmed by the time takerpayment needs to be sent, then the change is not visible to mm2... so i assume vin is empty because there are no UTXOs to use... kind of expected result... but i thought the purpose of this PR was to change exactly that

Feb 17 '25 15:02 cipig

the tx has empty vin (I have seen the same issue in zombie tests sometimes)

imagine you have a single ARRR UTXO, then you start a swap, trying to sell some ARRR ARRR takerfee is sent... then ARRR takerpaymet needs to use the change from takerfee... but if takerfee is not confirmed by the time takerpayment needs to be sent, then the change is not visible to mm2... so i assume vin is empty because there are no UTXOs to use... kind of expected result... but i thought the purpose of this PR was to change exactly that

this is exactly what this PR aims to fix..I think there's something missing somewhere. Checking

Feb 17 '25 15:02 borngraced

imagine you have a single ARRR UTXO, then you start a swap, trying to sell some ARRR ARRR takerfee is sent... then ARRR takerpaymet needs to use the change from takerfee... but if takerfee is not confirmed by the time takerpayment needs to be sent, then the change is not visible to mm2... so i assume vin is empty because there are no UTXOs to use... kind of expected result... but i thought the purpose of this PR was to change exactly that

This tx is okay by the look of it (absence of transparent vins is normal if a tx has a shielded spend). Maybe there is more info in the komodo debug.log around that time (could you plz search for txid 4498a4534bad9e0406822ad195bce306baa862a4f4bae3f469bbfd70ac8e88c7 and/or 'CheckTransaction' in the debug.log - sometimes errors are logged w/o txid)

Feb 17 '25 15:02 dimxy

This tx is okay by the look of it (absence of transparent vins is normal if a tx has a shielded spend). Maybe there is more info in the komodo debug.log around that time (could you plz search for txid 4498a4534bad9e0406822ad195bce306baa862a4f4bae3f469bbfd70ac8e88c7 and/or 'CheckTransaction' in the debug.log - sometimes errors are logged w/o txid)

the debug.log of ARRR on the electrums does not contain "4498a4534bad9e0406822ad195bce306baa862a4f4bae3f469bbfd70ac8e88c7"

found this entry

debug.log.3.gz:2025-02-14 13:05:55 ERROR: ContextualCheckTransaction(): transaction 7abf122c58608625f3ca866e7a67238f1af06408af48ceeb22f132003fd800ed is expired, expiry block 3308274 vs current block 3308277
debug.log.3.gz:2025-02-14 13:05:55 ERROR: AcceptToMemoryPool: ContextualCheckTransaction failed

but it's a different txid

Feb 17 '25 15:02 cipig

debug.log.3.gz:2025-02-14 13:05:55 ERROR: ContextualCheckTransaction(): transaction 7abf122c58608625f3ca866e7a67238f1af06408af48ceeb22f132003fd800ed is expired, expiry block 3308274 vs current block 3308277
debug.log.3.gz:2025-02-14 13:05:55 ERROR: AcceptToMemoryPool: ContextualCheckTransaction failed

but it's a different txid

BTW Looks like the librustcash sets DEFAULT_TX_EXPIRY_DELTA to 20 whereas the komodo code sets it as 200. Should not it be changed for us @borngraced?

Feb 17 '25 15:02 dimxy

7abf122c58608625f3ca866e7a67238f1af06408af48ceeb22f132003fd800ed

it's a different tx. The one in the error attached has "expiryheight": 3308511

No more 'CheckTransaction' logs?

Feb 17 '25 15:02 dimxy