dimxy

Results 81 comments of dimxy

> I have a question about how the feature is supposed to work in general: is it really required to run the background loop and keep additional context? What are...

> I have tried to simplify the `estimator_loop` as much as I could... Thank you for this, studying... I understand this code could be much simple. The use case I...

> 4\. Also, (just IMHO) wrapping `mpsc::Receiver` in `Arc` is a potential design problem. The `Single Consumer` pattern is not intended to be concurrently used in multiple threads (explicitly marked...

> @dimxy Yeah, I understand the idea. The proposal code actually implements it in a bit different way.. Yes I think it's better to use your code and let the...

> > I understand now Arc is not good here. I guess I should have used simply Mutex. Thank you for that. > > If possible, Mutex should be avoided...

Latest commits: - added eip1559 priority fee to eth withdraw and swaps. Priority fee is set for eth coin or token with "set_swap_transaction_fee_policy" rpc - added customised gas limit consts...

> Thanks for the PR! I have a question It's temporarily, I have added PRs with eip1559 support into our eth libs and temp use my repo until those PRs...

Above there are few fixes on review notes, also implemented couple of todos (coins params whether gas provider and which tx type are supported) plus some refactor of gas limit...

> @dimxy note that PR started to have conflicts 👀 updated

@KomodoPlatform/qa this PR adds support for eth [EIP-1559](https://eips.ethereum.org/EIPS/eip-1559) gas priority fee, for withdrawals and swaps. **Allow eip-1559 transactions for coins** To allow eip-1559 transactions (which have type 2) there is...