dimxy

AFAIK the `my_swap_status` RPC which returns the data above does not provide 'is_finished' or 'is_success' or 'recoverable' flags. So GUI figures out those statuses by analysing events returned by my_swap_status....

I also see differences, for a failed swap: in the swap exported data https://gist.github.com/dimxy/1b2e73a841778af41b7c443a72b1130f we see the swap was successfully refunded, but in the GUI swap history the swap was...

> Is this ready for review? I am doing final checks and will change the status for ready after that

> Thank you for this PR. Covers most of what I was working on here #2083. > > I will close mine when this is approved. I thought #2083 was...

> Does this PR require and docs updates? I've created a docs PR at [KomodoPlatform/komodo-docs-mdx#416](https://github.com/KomodoPlatform/komodo-docs-mdx/pull/416) for the related KF PR #2083 please advise in the docs PR if anything else...

> Need this [eab8902](https://github.com/KomodoPlatform/komodo-defi-framework/commit/eab8902d28607bbe9e8d706ee4a854f92e7ec954) to be checked before I can merge this @dimxy looks good

> I assume this will require updates to the coins repo? How often do the priority values change? Does `set_swap_transaction_fee_policy` involve a new config param in MM2.json? Yes we need...

> Using display_eth_address in such cases is inefficient, as it unnecessarily computes checksum_address each time, wasting resources. Okay, let's ensure we use display_eth_address only for returned results and make this...

> > BTW I can see the ethereum_types lib has implementation for 'Address' to string conversion. Let's use it maybe. > > can you provide code part or screenshot so...

This PR becomes important because evm tx type activation by version is added here - allows to do evm swaps with old nodes. Also a few fixes for that code...