dimxy

Results 81 comments of dimxy

> Is something needed in the coins file, or specific params needed during the coin activation? Gas fee estimator is supported for ETH-like coins with EIP-1559 implemented. To enabled it...

> @dimxy @shamardy could you please clarify what the priority of this feature (when its preferable to have it in production)? I see this pr is focusing on legacy swap....

Closing this PR because access lists did not show considerable advantage. Also, we decided to implement version in a different way

I'd suggest trying to use standard names (for which we could find their explanations in trading dictionaries) where this is appropriate. So I'd use standard terms like 'ask, bid, base,...

> nits here and there. other than the `filter_map` then `zip` thing, all nits :) tyvm: almost all the notes fixed here: 2a668ac87d1c5940011673959ee9c599501f0b5e

Regarding this: https://github.com/KomodoPlatform/komodo-defi-framework/pull/2362#discussion_r2094780625 I suggest I use the 'Close' price in the next PR (which actually does swaps with LR) and we will see how this affect swaps (We may...

I improved functions and structs naming (well, at least I tried). Also I extended the rpc structs to accept not only one currently supported but different kinds of sell/buy options....

> @smk762 please wait for @dimxy to approve my comment before using it in the docs PR, he might also modify if first before approval. I edited https://github.com/KomodoPlatform/komodo-defi-framework/pull/2545#issuecomment-3144098934 and added...

> > `1inch` API should be added to komodo proxy and then we will require no key in the headers from KDF side and it will work without the special...

> Is thing pending for a review? I ll resolve the conflicts first