dimxy

Internally we discussed that this feature can be helpful for extra flexibility with gas management. If your experience suggests it would create more problems than solve, let's not do it.

There is a statement in the web3 client that we use https://crates.io/crates/web3 that it is not actively maintained and for new projects it is recommended to use another client: https://github.com/gakonst/ethers-rs....

https://github.com/gakonst/ethers-rs is being deprecated too. This is the alternative https://github.com/alloy-rs/alloy and this https://github.com/foundry-rs/foundry

In addition, what happens if incorrect purpose is set for a segwit coin (44 instead of 84): if the hd wallet API or trezor wallet is used with a segwit...

I can see several segwit coins with no derivation path set at all. We did not assign it because there is no standard value for those coins?

> Info was sourced from https://github.com/satoshilabs/slips/blob/master/slip-0044.md a while ago. I see, I'll discuss with @shamardy what we should do with coins for which there is no assigned coin type

test_mm2_stops_immediately seems not working btw. I guess clear_running_swaps() is needed here too?

I like this PR. Q: could we extend it for a situation when swap was finished and the taker json has a false MakerPaymentSpendConfirmFailed event (false because in fact the...

Great work! I particularly like that the gas fee estimator now is within the common framework of event handling

I tried to use this PR and it appears to work okay. This is great work. I am about to approve it, to move forward and let GUI play with...