dimxy

Results 81 comments of dimxy

Conflicts resolved, PR is ready for review

> Conflicts resolved, PR is ready for review One important test fails. To draft for now..

> > Conflicts resolved, PR is ready for review > > One important test fails. To draft for now.. Looks like tests are okay now. I saw once failure of...

Here is the tx itself with the problem scriptSig: ``` "data" : { "tx_hash" : "751fb56af534657e12e234f8b9cbddc29fac4b7e9289c08fdd4485653d9110a0", "tx_hex" : "01000000020eb1f26ed67e9d99a3e1974dda4103975362cf42831a9234deaf92dedf8017e7020000006845304202205fa91d3dc0c88b1b0c2b5ecdf08b49c0458b6f10ff6b758b82c1934210f367fc021e51a96cf672048a44fef3256ba9a061b408f842b6b523624c28d6b5bbd1680121023c5ba1d7ef6fa015eb33defb3aba2a961898a51bbb7ff30344d07ba75ad3f289ffffffff2b82df45f7f8ebc7b562e0c3c8d4c99607fd3a11fa7b9dcac00d5378b30dfbe0000000006a4730440220517c0815e6068e8436d238ffd4c1dacecd3cc68a6bdc82332787567d18a23398022004a96396198a954890b99fd68e72b8531e41a13f7b8f1b8611a264d84364532f0121023c5ba1d7ef6fa015eb33defb3aba2a961898a51bbb7ff30344d07ba75ad3f289ffffffff02f1c30100000000001976a914ca1e04745e8ca0c60d8c5881531d51bec470743f88ac4965f405000000001976a91484c74592ed8ac05340906784d277ca4d4e0af08e88ac59439d68" }, "type" : "TakerFeeSent" ``` (There is also a new test...

fixed https://github.com/KomodoPlatform/komodo-defi-framework/pull/2591

Thank you for bringing this to attention. I guess the problem, which this issue is to solve, is that when you are developing a particular docker test you need to...

With service containers, to run docker tests locally w/o CI, users would have to run needed containers manually (or with some script), right? (Wondering though would it be possible to...

I have few questions: - in the curl sample in the PR description the `"mm2": 1` param is not needed, right? - in the same curl sample we enable TRX...

As I can see, we don't show premium in the orderbook so when users are viewing orderbook they see only order prices from 'setprice' rpc and are not aware of...

I am okay with the code in this PR, but I am not sure I am totally understand the whole premium concept (like how it should be calculated and paid)....