dimxy

@KomodoPlatform/qa this PR changes trade fees as part of initiatives to solve problems with high transaction fees. This all affects ETH only. **"trade_preimage" rpc does not include refund fee** The...

> Please add comments documenting new coin configs and new APIs, or API changes for QA team. done in https://github.com/KomodoPlatform/komodo-defi-framework/pull/2051#issuecomment-2117979019

I think I have a general question: Why do we use 'fee per KB' units? I see in explorers or wallets that usually 'fee per vB' is used. Would this...

btw there is a similar feature https://docs.rs/thiserror/latest/thiserror/. An interesting feature in it is formatting error message with interpolating nested error

I tried EnumFromStringify with the new option, like: ``` #[from_stringify("SPVError")] SPVError(SPVError), ``` I think this may be preferable, because when printing the outer error in the debug format this option...

BTW the function derive_enum_from_macro in the unsupported case of 'struct' or 'union' always returns ENUM_FROM_INNER_IDENT tag in the error, although derive_enum_from_macro fn could be also called for EnumFromStringify and EnumFromTrait

Also I think you need to update the doc for EnumFromStringify: * This note `// E.G, this converts from Bar, Man to FooBar::Bar(String)` does not fully match to the example...

In the recent 16 commits I added a 'version' field to negotiation protocol. This is done in the current PR to activate burning of non-kmd part of dex fee (a...

TODO: add rpc to set custom gas limit for swap evm calls

> > TODO: add rpc to set custom gas limit for swap evm calls > > May i ask why we need/want that? It sounds dangerous to me... if you...