coins icon indicating copy to clipboard operation
coins copied to clipboard

update segwit derivation paths

Open smk762 opened this issue 2 years ago • 3 comments

Closes: https://github.com/KomodoPlatform/coins/issues/694 PR: https://github.com/KomodoPlatform/komodo-defi-framework/pull/1984

smk762 avatar Oct 30 '23 06:10 smk762

I can see several segwit coins with no derivation path set at all. We did not assign it because there is no standard value for those coins?

dimxy avatar Oct 30 '23 11:10 dimxy

I can see several segwit coins with no derivation path set at all. We did not assign it because there is no standard value for those coins?

Info was sourced from https://github.com/satoshilabs/slips/blob/master/slip-0044.md a while ago. trezor_coin value comes from https://trezor.io/coins where available.

I've added a check to the config gen script to highlight the coins with missing / incorrect derivation path, results are:

Segwit coins with no derivation path: ['BSTY-segwit', 'tQTUM-segwit', 'tBTC-segwit', 'WHIVE-segwit']
Segwit coins with bad derivation path: []
Segwit coins with no trezor coin: [
    'BSTY-segwit',
    'CDN-segwit',
    'CY-segwit',
    'LBC-segwit',
    'LCC-segwit',
    'WCN-segwit',
    'tQTUM-segwit',
    'tBTC-segwit',
    'XEP-segwit',
    'XMY-segwit',
    'WHIVE-segwit'
]

I rechecked the sources and found no new data to update the coins file at this time.

smk762 avatar Nov 03 '23 09:11 smk762

Info was sourced from https://github.com/satoshilabs/slips/blob/master/slip-0044.md a while ago.

I see, I'll discuss with @shamardy what we should do with coins for which there is no assigned coin type

dimxy avatar Nov 04 '23 09:11 dimxy

closing as stale, issue solved by https://github.com/KomodoPlatform/coins/pull/1355

smk762 avatar May 30 '25 09:05 smk762