atomicDEX-API icon indicating copy to clipboard operation
atomicDEX-API copied to clipboard

enhancement(utxo): improve trade and withdraw fee calculations

Open borngraced opened this issue 11 months ago • 3 comments

UTXO Fee Improvements:

  1. fee-per-kb calculation and improvement: Ensure UTXO fee calculation is based on transaction size and some improvements.
  2. Custom Fee Options: Enable users to select low, default/normal, or high priority fee levels for UTXO withdrawals.

Withdraw using UtxoPriority::Low

{
	"userpass": "SamopE160!",
	"method": "withdraw",
	"mmrpc": "2.0",
	"params": {
	   "to": "RCKfmv1X4oZHhGgb9mVD8XnkubAerWEcQ4",
	   "max": false,
	   "coin": "DOC",
	   "amount": "1000",
	   "fee": {
	      "type": "UtxoPriority",
	       "priority": "Low",
	    }
	}
}

#1835

borngraced avatar Mar 08 '24 21:03 borngraced

@borngraced please resolve conflicts in this PR

shamardy avatar May 06 '24 14:05 shamardy

I think I have a general question: Why do we use 'fee per KB' units? I see in explorers or wallets that usually 'fee per vB' is used. Would this not be more convenient for users if we use the same? Then users may check actual fees in explorer and use it in our wallet without conversion. (BTW maybe some users may not clearly understand the 'vByte' idea but this should not be a problem as they can just use it directly 'as is')

dimxy avatar Jun 19 '24 18:06 dimxy

ps @borngraced I see that PR lint fails

laruh avatar Jun 20 '24 05:06 laruh