microshift
microshift copied to clipboard
openshift
add user-facing config for ovn-kubernetes CNI
Putting a hold for the API team to take some time to consider how to handle this new configuration parameter going forward. We are currently working on rewriting the existing configuration to be more in line with OCP so adding a dependency on the existing configuration of MicroShift will be problematic for us.
/hold
Putting a hold for the API team to take some time to consider how to handle this new configuration parameter going forward. We are currently working on rewriting the existing configuration to be more in line with OCP so adding a dependency on the existing configuration of MicroShift will be problematic for us.
/hold
@dgrisonnet The PR is updated to use a separate config file for ovn-kubernetes.
Unholding since the initial concerns were cleared in this thread: https://github.com/openshift/microshift/pull/1030#discussion_r1006118685
/unhold
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mangelajo, zshi-redhat
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [mangelajo,zshi-redhat]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
@zshi-redhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| ci/prow/periodic-ocp-4.13-images | d5875a2d1ef76fa9076893bc8d7989ceed1542cb | link | true | /test periodic-ocp-4.13-images |
Full PR test history. Your PR dashboard.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.