kube-state-metrics
kube-state-metrics copied to clipboard
kubernetes
Deprecate VPA
- [x] Deprecate VPA metrics.
- [x] Inform users about the deprecation (print a warning to
stdout). - [x] Document an alternative approach using the CRD capabilities we have now.
Signed-off-by: Pranshu Srivastava [email protected]
How does this change affect the cardinality of KSM: No change (VPA metrics will be removed in v2.8.0).
Which issue(s) this PR fixes: Partially targets #1718.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fpetkovski, rexagod
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [fpetkovski]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
The unit tests are failing, you need to the update the test metadata to include the deprecation notice: https://github.com/kubernetes/kube-state-metrics/blob/master/internal/store/verticalpodautoscaler_test.go#L33-L40
I am still very much against cutting a new major version of ksm just for deprecating VPA metrics. This is not an overhaul of the codebase, we are just deprecating some metrics and replacing them with new ones. See it as a renaming of metrics rather than a complete removal.
Also, it is worth noting that all the VPA metrics are experimental so although they have been in the codebase for a while, users shouldn't expect them to never change.
Holding until we've reached a consensus. /hold
I am still very much against cutting a new major version of ksm just for deprecating VPA metrics. This is not an overhaul of the codebase, we are just deprecating some metrics and replacing them with new ones. See it as a renaming of metrics rather than a complete removal.
Also, it is worth noting that all the VPA metrics are experimental so although they have been in the codebase for a while, users shouldn't expect them to never change.
Holding until we've reached a consensus. /hold
Yeah, cutting a release for deleting experimental metrics seems a bit much to me too.
Reverted to v2.9.0 (https://github.com/kubernetes/kube-state-metrics/pull/1835#discussion_r978888062).
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: fpetkovski, mrueg, rexagod
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [fpetkovski,mrueg]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
So what are the alternatives now to get those metrics ? Sry starting with vpa just to have free recommendations instead of paying 15k to some random saas.
There is a doc explaining how to get them back in https://github.com/kubernetes/kube-state-metrics/blob/main/docs/customresourcestate-metrics.md#verticalpodautoscaler