Doug Fawley comments

Results 456 comments of


                                            Doug Fawley

Improve `regenerate.sh` to use the correct proto compiler version

@avinilcodes - Thanks! Note that most people on our team use both linux and macOS, so the script should be able to handle this properly on both systems, or at...

Improve `regenerate.sh` to use the correct proto compiler version

We don't want to always use the latest version because that would require updates to our generated code frequently. We have a release document that includes updating other dependencies that...

Improve `regenerate.sh` to use the correct proto compiler version

Similar to the other issue, @Aditya-Sood - LMK if you still want this.

For unary methods, received messages are put into buffer from the pool, but buffer is never returned back to pool.

I approved #6766; we need a second review before merging it. Sorry for the delays.

For unary methods, received messages are put into buffer from the pool, but buffer is never returned back to pool.

@efremovmi The gRPC benchmarks (https://grafana-dot-grpc-testing.appspot.com/?orgId=1) unfortunately don't collect memory usage statistics. Maybe another user has some data they can share?

internal/credentials/xds: add unit test for HandshakeInfo.Equal

Let us know if you still want this @Aditya-Sood - I already assigned a few other things to you and don't want to overwhelm.

protoc-gen-go-grpc: add tests

@Aditya-Sood ?

protoc-gen-go-grpc: add tests

@zedGGs that seems unrelated. At the moment there are no tests, which means any changes made here have to be tested manually. If `Annotate` is deprecated then we should separately...

Apply max send size to un-compressed data

Would you mind reworking this so it implements step 1 from the above list?

interop: Replace context.Background() with passed ctx

> one query - is the use of CancelFunc unidirectional (parent to child ctx)? or can a child be allowed to cancel the ctx for itself and its siblings? Derived...