grpc-go icon indicating copy to clipboard operation
grpc-go copied to clipboard

internal/credentials/xds: add unit test for HandshakeInfo.Equal

Open easwars opened this issue 1 year ago • 7 comments

We made the Equal method actual perform a deep equal instead of pointer equality. We should add tests for it. https://github.com/grpc/grpc-go/blob/master/internal/credentials/xds/handshake_info.go#L47

easwars avatar Aug 22 '23 17:08 easwars

hi @ginayeh, can I pick this up?

Aditya-Sood avatar Nov 04 '23 04:11 Aditya-Sood

Let us know if you still want this @Aditya-Sood - I already assigned a few other things to you and don't want to overwhelm.

dfawley avatar Nov 07 '23 18:11 dfawley

hi @dfawley, yes I've responded to the action items for me on the open PRs I will start working on #6763, can pick this up after that?

Aditya-Sood avatar Nov 08 '23 06:11 Aditya-Sood

@arvindbr8 I would love to take this one, if you think it's fine feel free to assign me

miledxz avatar Feb 05 '24 07:02 miledxz

@zedGGs -- Thanks for your interest. But it seems like we have a PR in flight. I'm more than happy to reserve this to you until we have merged that one in.

arvindbr8 avatar Feb 08 '24 21:02 arvindbr8

@arvindbr8 feel free to assign me on this since we finalised ongoing pr already

miledxz avatar Jun 29 '24 18:06 miledxz