grpc-go icon indicating copy to clipboard operation
grpc-go copied to clipboard

protoc-gen-go-grpc: add tests

Open dfawley opened this issue 1 year ago • 6 comments

We don't currently have any tests in protoc-gen-go-grpc. We should add something simple at least:

  1. Create a .proto file with streaming / unary RPCs.
  2. Generate the .pb.go file(s) from it and commit it/them.
  3. Write a test that does (2) and diffs the results with the committed file(s).

dfawley avatar Oct 25 '23 20:10 dfawley

hi @dfawley, can I pick this up?

Aditya-Sood avatar Nov 04 '23 04:11 Aditya-Sood

@Aditya-Sood ?

dfawley avatar Nov 07 '23 18:11 dfawley

thank you Doug, as suggested I will close the other issue and then pick this up

Aditya-Sood avatar Nov 08 '23 06:11 Aditya-Sood

@dfawley , Im looking what could be done here, but Annotate from protogen has been deprecated, do we need to take that in consideration too ?

miledxz avatar Dec 16 '23 01:12 miledxz

@zedGGs that seems unrelated. At the moment there are no tests, which means any changes made here have to be tested manually. If Annotate is deprecated then we should separately look into switching to whatever the alternative is, and having tests in place before making that change would help to ensure nothing is broken by the change.

dfawley avatar Dec 18 '23 17:12 dfawley

@dfawley I can take this one, if thats okey for you, I will add tests for unary RPCs, and if that goes well in pull request, I can also add tests for other RPCs streaming options,

feel free to assign me

miledxz avatar Dec 31 '23 11:12 miledxz