Doug Fawley

Results 458 comments of Doug Fawley

If you have a proposal for how to do this, then please include it here. Otherwise, it's a bit tricky of a situation since the stats handler may keep a...

> I don't know if this will be considered a breaking change or not. Unfortunately, yes, it would be, as the documentation doesn't currently forbid it. Yes, `stats` is an...

This seems to be worth doing eventually, and we could phase it now by doing a conditional build of the grpcrand package. I am fairly sure I added this package...

@kmirzavaziri sure, that sounds good. The conditional build I had in mind was just based on the Go version, by the way, not a custom build flag.

> We should probably link to that, from our call options: MaxCallRecvMsgSize and MaxCallSendMsgSize It's fine to mention it, but of course protobuf isn't the only codec we support, so...

We _might_ be doing some work on codecs next quarter depending on internal priorities. If so, the most likely change would be to use a scatter-gather API that references the...

Apologies - now that I looked more closely at the proposal itself, I noticed that you're looking at the _sending_ of data (`Marshal`), whereas my comment was mostly about the...

https://github.com/grpc/grpc-go/actions/runs/5648427585/job/15300626084?pr=6471

https://github.com/grpc/grpc-go/actions/runs/5660143001/job/15335218210?pr=6477

Let's leave this open to replace our use of `actions/upload-release-asset@v1` with [softprops/action-gh-release](https://github.com/softprops/action-gh-release)