Doug Fawley

Results 450 comments of Doug Fawley

@arvindbr8 is out of town for a couple weeks; will resume when he returns.

> If you rebase your branch to master In general, it's best to not rebase a PR from master until the reviews are done, as it messes up github diffs...

We need more information to proceed, here. 1. What version of the code are you looking at? master@HEAD doesn't have any relevant code on those lines. 2. How did you...

I don't see any issue here. If you can be much more specific, and ideally reference master@HEAD or something more recent, then we could investigate further.

Please fill in similar information as requested in #6326.

I don't see any issue here. If you can be much more specific, and ideally reference master@HEAD or something more recent, then we could investigate further.

I don't understand the significance of what you're talking about. Context cancelation or deadline expiration are asynchronous events from the write to the network. So it's always possible that the...

> @dfawley Any thoughts on this? Do you think it make sense to re-check the context when "dequeueing" the write on the http client side? No, because you can't get...

> Idk if would be a huge overhead to always copy this data to a local buffer. My guess is it would be, because it would escape the stack, and...