Doug Fawley

Results 459 comments of Doug Fawley

I'm pretty sure it's decided that we will not be pursuing this approach anymore.

Oh sorry, it looks like there is a new merge conflict; can you resolve it please @Clement-Jean ?

Sorry, I broke you again. :) I think I fixed it here, though.

> @arvindbr8 I'm not entirely sure about the "unresolved" comment. What did you mean? I think he meant `status.WithDetails`'s method signature which I thought when I looked yesterday did not...

> There seem to be still some work to do to remove the old package. Could you take a look at the remaining usages (channelz, credentials, internal/pretty, and xds/internal/xdsclient/bootstrap) and...

Would you mind reverting all those changes since the last review so we can submit the already-reviewed code without delay? You can move them into another branch and we can...

Yes, I think we're all clear now to finish it. Unfortunately, it looks like we'll still keep the dependency in perpetuity because of testing in https://github.com/grpc/grpc-go/blob/cce163274b6cb9de2b2bf0bc742384e5755fee42/reflection/grpc_testing_not_regenerate/testv3.go#L41C9-L41C41

This isn't exactly as I would have said it. The behavior you're seeing is what the server is doing. The server is programmed with the knowledge that you are doing...

Hi @and1truong, Such a wide-sweeping change would require cross-language agreement for adding this. Instead, maybe you can add a global in the `resolver/dns` package to control this (which would be...

@Aditya-Sood Yes, that would be great! But note that we are going to be moving `stress/*` to `interop/stress/*`, so you might want to wait until that's done, first.