grpc-go
grpc-go copied to clipboard
interop: Replace context.Background() with passed ctx
Fixes #6763
RELEASE NOTES: none
Codecov Report
Merging #6827 (1ed10f4) into master (7935c4f) will increase coverage by
0.35%
. Report is 49 commits behind head on master. The diff coverage isn/a
.
Additional details and impacted files
@@ Coverage Diff @@
## master #6827 +/- ##
==========================================
+ Coverage 83.40% 83.75% +0.35%
==========================================
Files 285 287 +2
Lines 30879 30928 +49
==========================================
+ Hits 25754 25904 +150
+ Misses 4053 3963 -90
+ Partials 1072 1061 -11
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.
hi @dfawley, could you please reopen the PR? I have pushed the code review changes now
thanks @dfawley, I've pushed the change in the latest commit
one query - is the use of CancelFunc
unidirectional (parent to child ctx)? or can a child be allowed to cancel the ctx for itself and its siblings?
one query - is the use of CancelFunc unidirectional (parent to child ctx)? or can a child be allowed to cancel the ctx for itself and its siblings?
Derived contexts cannot cancel their parents/siblings and cannot be cancelled via a method on the context itself (by design).
The thing that creates a context should be the only thing able to cancel it.
thank you for the clarifications @dfawley! I've pushed the changes to the branch
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed.
hi @dfawley, thanks for the feedback - I'd missed the obvious use of WithTimeout
instead of WithDeadline
have pushed the review changes in new commit