Doug Fawley
Doug Fawley
Let's leave this issue open to track: - [ ] Release of protoc-gen-go-grpc - [ ] Flag flip to default on - [ ] Release of protoc-gen-go-grpc - [ ]...
@ukai, Why do you believe retries are not occurring? Can you provide logs with debugging enabled? https://github.com/grpc/grpc-go#how-to-turn-on-logging
That's not a bad idea. That should involve modifying the error returned from the RPC here: https://github.com/grpc/grpc-go/blob/4f43d2e91d2d3c0f9c37cf871bd3e2d322743f3e/stream.go#L688 We should also find out what Java/C++ are doing for this case (and...
After talking with Java/Node teams, they don't do anything like this, either. We'd have to be very careful to make it clear what the server produced. There's no precedent in...
(Sorry, I should have removed the label.)
Anything documented as "deprecated" but that doesn't also state that it may/will be removed in the future, will be supported throughout 1.x releases, so `WithCompressor` can be used without worrying...
Another option here would be to pass `UseCompressor` and `SetSendCompressor` an optional `any` argument that gets passed to the compressor as an extra parameter to `Compress`. This would not be...
From a quick reading, it looks like none of these approaches requires decompression to have access to anything besides the compressed data -- is that correct? So we don't have...
My proposed change, then would be: ```go package grpc func UseCompressor(name string, compressorOptions ...any) CallOption {} func SetSendCompressor(ctx context.Context, name string, compressorOptions ...any) error {} ``` ```go package encoding type...
It's sad that a correctness typo can't be fixed without the user signing a CLA. Can a maintainer send a similar PR?