David Wengier

Results 343 comments of David Wengier

Your logging methods need cancellation tokens, but I don't think I have any more useful comments that haven't already been commented.

I have zero context here, I was just commenting on the issue to prevent an overzealous community contribution from blindly updating the license. If this is causing problems, but is...

Boy does github suck for long reviews. I think "Add single comment" might work better, but as it is, I have no idea what question this is answering, for example:...

I'll leave someone else to comment on whether it's needed, but I'm 99% sure the license is accurate. Certainly it shouldn't be MIT.

It's worth noting that Visual Studio has the ability to toggle the completion mode so that no matter what is being typed, completion won't get in the way unless you...

@jimmylewis are these rolled out in the html editor? I'm implementing this, and its all cool, but I'm wondering if you got any pushback on number 3, since it shows...

I think what surprised me most was that it is offered for elements without content too. I can see the usefulness of it, but not sure how Razor devs will...

How would you feel about making the "Remove tag" code action be a resolvable one? Seems like potentially a huge amount of json being passed around in order to show...

https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/431909

@michaelcsikos Could you expand a little on what you're seeing in 17.4, compared to previous versions? We don't actually control the undo stack at all in this repo, but there...