David Wengier

Failed because there was no nuget restore done.. but it passes in `-restore`? No idea! https://dev.azure.com/dnceng/internal/_build/results?buildId=2012965&view=logs&j=7c8326b9-0a5f-532a-e6de-db8515c72d9a&t=06c773de-aa2b-5fd5-6aaa-ea6cf87a3134&l=205

Changing msbuildengine doesn't have any effect. Putting `Restore` in the list of targets in `rzls.csproj` doesn't have any effect. ~Maybe i'll try just separating build and publish?~ Nope that doesn't...

Nice find! Looks like it was done for perf, and to allow building net5 projects: https://github.com/dotnet/razor-tooling/pull/1902 I think our builds are fast enough and building Razor.sln is fine, we can...

Val build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2013054&view=results

Perhaps it wasn't a superset at the time of that PR? If my val build passes then it will at least confirm that the vs build engine can build everything,...

New val build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2013190&view=results

Test insertion https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/428115

Damnit, SymbolCheck still failed, and failed worse now. Previously only one DLL wasn't uploading symbols, now its more of them. So previously the second build was causing issues, but only...

Thanks for the report @janseris! Regarding the "not working at all" issue, it looks like https://github.com/dotnet/razor-tooling/pull/6495 got into 17.3, which caused this regression. It was subsequently fixed in https://github.com/dotnet/razor-tooling/pull/6550 which...

Looks like Roslyn is swallowing the caret information it has, when returning results via LSP. Logged https://github.com/dotnet/roslyn/issues/63811