roslyn icon indicating copy to clipboard operation
roslyn copied to clipboard

Create CLaSP Framework surface area

Open ryanbrandenburg opened this issue 2 years ago • 2 comments

Partner PR for https://github.com/dotnet/roslyn/pull/62924 intended to make it more clear what the public-facing surface area being proposed is.

ryanbrandenburg avatar Aug 02 '22 22:08 ryanbrandenburg

So, one thing that might be super helpful (either in this, or a sibling pr) would be:

here's a Program.Main that shows how to instantiate everything to get a working Queue/Manager/Services/etc. that is now up and running (perhaps given the presumption that the JsonRpc object is ready to go). e.g.:

Step 1: instantiate the queue. Step 2: instantiate the frob with the queue. Step 3: register handle X which handles message Y with the service.

I'm def not getting how all these pieces fit together yet.

CyrusNajmabadi avatar Aug 03 '22 00:08 CyrusNajmabadi

So, one thing that might be super helpful (either in this, or a sibling pr) would be:

here's a Program.Main that shows how to instantiate everything to get a working Queue/Manager/Services/etc. that is now up and running (perhaps given the presumption that the JsonRpc object is ready to go). e.g.:

Step 1: instantiate the queue. Step 2: instantiate the frob with the queue. Step 3: register handle X which handles message Y with the service.

I'm def not getting how all these pieces fit together yet.

Does https://github.com/ryanbrandenburg/roslyn/tree/VSServer/src/Features/LanguageServer/CommonLanguageServerProtocol.Framework.Example fill that gap for you?

ryanbrandenburg avatar Aug 09 '22 21:08 ryanbrandenburg

Your logging methods need cancellation tokens, but I don't think I have any more useful comments that haven't already been commented.

davidwengier avatar Aug 17 '22 06:08 davidwengier

Killing this PR as the Surface Area seems to be mostly nailed down. If you still have feedback feel free to take it to https://github.com/dotnet/roslyn/pull/62924.

ryanbrandenburg avatar Aug 31 '22 23:08 ryanbrandenburg