roslyn
roslyn copied to clipboard
Create CLaSP Framework surface area
Partner PR for https://github.com/dotnet/roslyn/pull/62924 intended to make it more clear what the public-facing surface area being proposed is.
So, one thing that might be super helpful (either in this, or a sibling pr) would be:
here's a Program.Main that shows how to instantiate everything to get a working Queue/Manager/Services/etc. that is now up and running (perhaps given the presumption that the JsonRpc object is ready to go). e.g.:
Step 1: instantiate the queue. Step 2: instantiate the frob with the queue. Step 3: register handle X which handles message Y with the service.
I'm def not getting how all these pieces fit together yet.
So, one thing that might be super helpful (either in this, or a sibling pr) would be:
here's a Program.Main that shows how to instantiate everything to get a working Queue/Manager/Services/etc. that is now up and running (perhaps given the presumption that the JsonRpc object is ready to go). e.g.:
Step 1: instantiate the queue. Step 2: instantiate the frob with the queue. Step 3: register handle X which handles message Y with the service.
I'm def not getting how all these pieces fit together yet.
Does https://github.com/ryanbrandenburg/roslyn/tree/VSServer/src/Features/LanguageServer/CommonLanguageServerProtocol.Framework.Example fill that gap for you?
Your logging methods need cancellation tokens, but I don't think I have any more useful comments that haven't already been commented.
Killing this PR as the Surface Area seems to be mostly nailed down. If you still have feedback feel free to take it to https://github.com/dotnet/roslyn/pull/62924.