David Wengier

Results 343 comments of David Wengier

Generally speaking, only open files. I think we report some issues for closed files in VS Code when UseOmniSharp is false, but thats a happy accident rather than deliberate choice.

Like https://github.com/dotnet/vscode-csharp/issues/6852, seems like our closed file support might have stopped working.

Been a few reports recently it seems, like https://github.com/dotnet/vscode-csharp/issues/6921 and https://github.com/dotnet/vscode-csharp/issues/4580#issuecomment-1912001583, where maybe our closed file stuff has changed. We could easily be broken by a change to Roslyn here...

This has nothing to do with me, but personally speaking I also think the toasts for every failed LSP request are annoying and wish they could be turned off or...

Confirmed that `mscorlib` is not coming through from CPS (`project.References.OfType()`) for VB projects, only C#.

Looking at the design time build, RAR doesn't include mscorlib.dll for VB projects. CPS does use the RAR output for references, though it doesn't block on them obviously. I'm not...

> The designer is blocked on a design build anyway (that's what the results of the references are from), so that's not the problem. On my local machine if I...

Razor tooling, in general, is not involved in build. If its a fast up to date check issue, then its probably something missing from the Razor SDK props or targets...

@drewnoakes is Razor missing something from our FUTD items that allows the project system to track items being removed from the project?