roslyn icon indicating copy to clipboard operation
roslyn copied to clipboard

Update License for Roslyn compilers script GenerateSdkPackages to MIT

Open janani66 opened this issue 2 years ago • 6 comments

Version Used: .NET7 main branch

Steps to Reproduce:

1.See https://github.com/dotnet/roslyn/blob/main/scripts/GenerateSdkPackages/base.nuspec#L9 -- this has the reference to http://go.microsoft.com/fwlink/?LinkID=614949 which points to the MICROSOFT VISUAL STUDIO 2015 SOFTWARE DEVELOPMENT KIT License

(A sharplab repro is ideal for compiler/language issues whenever possible)

Expected Behavior: This should point to the MIT License

Actual Behavior: Points to https://visualstudio.microsoft.com/license-terms/mt171586/ which has the MICROSOFT VISUAL STUDIO 2015 SOFTWARE DEVELOPMENT KIT License.

janani66 avatar Aug 07 '22 15:08 janani66

Is GenerateSdkPackages actually used? Maybe it could be deleted entirely.

Youssef1313 avatar Aug 08 '22 07:08 Youssef1313

I'll leave someone else to comment on whether it's needed, but I'm 99% sure the license is accurate. Certainly it shouldn't be MIT.

davidwengier avatar Aug 08 '22 09:08 davidwengier

cc @crummel @lbussell @MichaelSimons

omajid avatar Aug 08 '22 21:08 omajid

@jaredpar - this license is popping up in IBMs open source license scans. Can you help determine if it's correct?

Seems like the contents of /scripts isn't particularly interesting from a downstream source-build perspective. @crummel, do you know what RH does with this?

leecow avatar Aug 10 '22 21:08 leecow

I'll leave someone else to comment on whether it's needed, but I'm 99% sure the license is accurate. Certainly it shouldn't be MIT.

This is correct. To the best of my recollection this is how we used to build SDK packages for inclusion in Visual Studio. Those do require the standard VS redist license which is used here.

Is GenerateSdkPackages actually used? Maybe it could be deleted entirely.

I think this can be deleted. It's not used anymore. At least I'm going to send a PR to delete this and see if anyone screams.

jaredpar avatar Aug 10 '22 21:08 jaredpar

Deleting the GenerateSdkPackages if they are not used will resolve the licensing issue for us.

janani66 avatar Aug 10 '22 21:08 janani66