Jordan Eldredge

Results 378 comments of Jordan Eldredge

I love the idea, and this is something I would love for us to have. That said, I think there is at least one questions we should answer first: How...

Thanks for the report. I think we should probably filter these records out of the store when serializing to JSON. Would you be up to opening a PR that does...

Good callout. Let me open a diff.

Looks like `@catch` and `@inline` have a bug. I'll reply on https://github.com/facebook/relay/issues/5069 In the case you outlined about `brandById`, `@catch` would handle errors reported by the `brandById` field, but not...

Interesting. Thanks for the report. So, if I understand correctly, the bug triggers when: 1. The `first` argument to your connection field is provided by a fragment variable with a...

Thanks for the report. The compiler is supposed to insert the `UserFullNameFragment` fragment. Is it possible to put together a minimal example? Sorry this has been wasting your time. Hopefully...

Thank you both for the reports and sorry for the excessive delay. I was able to use @michael-haberzettel's repro to identify the issue. We are not correctly processing resolver fragments...

I suspect our use of `use` will be simply as an implementation detail to replace throwing a promise. Is there something specific you were hoping to achieve by having direct...