Jordan Eldredge

Results 370 comments of Jordan Eldredge

Yeah, this should be enforced by the compiler. Maybe somewhere around [here](https://github.com/facebook/relay/blob/33ad7cc6b6cfa1f2cc80f5a15ba7b0c652dc3d5a/compiler/crates/relay-compiler/src/file_source/extract_graphql.rs#L60)? Would you like to work on a PR?

One outstanding question regarding this approach is "will we be able to find an additive syntax to denote 'null only on error' that is palatable?". Some folks from the Nullability...

This sounds like a reasonable ask. Do you want to just have access to the audio context and to control UI/rendering yourself, or do you want to use the Milkdrop...

This looks like a bug in our docs. A DOM node _is_ required, but our docs imply it can be omitted: https://docs.webamp.org/docs/API/instance-methods#renderwhenreadydomnode-htmlelement-promisevoid Sorry for the confusion that caused. Would you...

Sorry I missed this. I know the problem you're highlighting, but I'm a little hesitant to take this on since there are places where we do poke (lightly) into private...

## Connect I think leaving them behind is probably fine for now. We can revisit if we get significant pushback. ## Store Enhancers Agree, next step is to pressure test...

Re selector arguments, I think from React's perspective, there are no selector arguments. They must be pre-bound into the selector, or use a "higher order selector" where the selector returns...

Not super happy about adding a magic number here. I think we need to wait until we can find a proper solution. Overall, I think we need to get to...

GitHub CI is pointing out legit lint errors here.