Jordan Eldredge
Jordan Eldredge
Sorry for the extreme delay. Looks like there are now merge conflicts and I can't import the PR if it has merge conflicts. Do you mind rebasing?
Would love a more complete understanding of what problem(s) we're trying to solve here. Here's what I'm inferring: The babel plugin currently needs to be able to see the Relay...
Thanks for your work on this! It makes sense to me. A few thoughts: 1. What do you think about moving this directly into the `relay-compiler` NPM package? The compiler...
Hey @leops thanks for looking into this. Could you open an issue (or find an existing one) on the Watchman repo? Would love to rule out fixing this at the...
I hear you. I can import tomorrow.
Personally I think a JavaScript desktop app is antithetical to much of what people loved about Winamp (native app, etc). Webamp was always intended as a novelty to show what's...
Closing since the diff internally was abandoned.
I was able to [reproduce in the compiler explorer](https://relay.dev/compiler-explorer/#enc=1&schemaText=C4TwDgpgBAigrhATiKBvAUFKALCAbPAewC4oBlYRASwDsBzTKAKwGdSLr70BfddFgMa4AtgEM0jAI4JkpeEhA8gA&documentText=I4VwpgTgngBAzhAxgQQA6oIrmjA3gKBhgAswAbMge0JgCs58BfIA&inputWindow=document&outputType=operation&no_inline=true&enable_3d_branch_arg_generation=true&actor_change_support=true&text_artifacts=true&skip_printing_nulls=false&compact_query_text=false&enable_fragment_aliases=false&enforce_fragment_alias_where_ambiguous=false&enable_catch_directive_transform=false&disallow_required_on_non_null_fields=false&language=typescript). Likely some bug in our `@match` validation [here](https://github.com/facebook/relay/blob/fc5894ab7aa298340babd65d8e0d85fce8e0bee8/compiler/crates/relay-transforms/src/match_/match_transform.rs#L176-L193) or more likely [here](https://github.com/facebook/relay/blob/fc5894ab7aa298340babd65d8e0d85fce8e0bee8/compiler/crates/relay-transforms/src/match_/match_transform.rs#L865)
I don't think we have active plans to work on this this, but folks are welcome to look at the code pointers I shared and work on a fix or...