Jordan Eldredge

Results 370 comments of Jordan Eldredge

We are planing to land public documentation of resolvers in Dec/Jan but in the mean time, Live Resolvers can return a suspense sentinel to indicate that they are in a...

> We generate inlined queries from normalization ASTs in JS, so this is somewhat slow. (~1.5s for ~300 queries). It's quite nice to be able to see the effect your...

> @captbaritone Could you approve the workflow for me? Done

I can see this is somehow related to us not doing [`selections_to_map`](https://github.com/facebook/relay/blob/main/compiler/crates/relay-typegen/src/visit.rs#L1216) as we do for linked field selections for [all raw response selection sets](https://github.com/facebook/relay/blob/main/compiler/crates/relay-typegen/src/visit.rs#L2398). However blindly adding it results...

My apologies, I didn't see https://github.com/facebook/relay/pull/4915 linked here. @evanyeung will followup on the PR.

cc @mjmahone in case you have context on why this is not "must". You mentioned that this might have been an intentional choice to allow servers to use errors to...

Looks like we're waiting on CLA check here. @MichaelSnowden do you mind signing the CLA so we can merge?