Jordan Eldredge

Results 370 comments of Jordan Eldredge

One challenge I see with this is that it presents the appearance that one could do: ```ts const foo = ``; const query = graphql(foo); ``` Or even ```ts const...

> Some context as to why I'm asking for this: [...] I don't know that this specific issue is common enough to merit the complexity/risk added here. But I am...

I don't think it's worth adding the complexity to Relay compiler/babel transform/new lint rule and adding the additional possibility of overmatching on graphql functions, and additional mental overhead of there...

I'd like to have a better understanding of how we will be able to enable this improved TS typing to ensure it's going to work out well before we start...

Cc @alloy this could be a pretty big quality of life improvement for typescript users. No need to add type params to useFragment and friends. But we might want your...

Does it have to be done as a single file? Is there perhaps way to achieve this using declarations such that each declaration actually lives in the fragment/operations's own file?...

I think this relates to these lines: * https://github.com/facebook/relay/blob/87d1ef64ad33543becde1af9c17444943215eb08/compiler/crates/relay-typegen/src/write.rs#L191 * https://github.com/facebook/relay/blob/87d1ef64ad33543becde1af9c17444943215eb08/compiler/crates/relay-typegen/src/write.rs#L470 We actually have a few integration tests which currently show this broken behavior. For example: * https://github.com/facebook/relay/blob/87d1ef64ad33543becde1af9c17444943215eb08/compiler/crates/relay-compiler/tests/relay_compiler_integration/fixtures/typescript_resolver_type_import.expected#L40C35-L40C54 @drewatk do...

Note: Removing those `== Flow` test seems to add the required imports, but also adds some unused imports which I know can be an issue for typechecking.