Jordan Eldredge

Results 370 comments of Jordan Eldredge

Hey @Markionium thanks for picking this up! I agree that attaching the context to the store is the right choice. However, rather than accessing the context via a magic function,...

Connecting the dots. @alloy and I have been discussing this a bit more on this Gist: https://gist.github.com/alloy/f0c9c90ff7a28f3b17850021488979d5

Looks like this is getting close, but still in draft. Give me a ping when this is ready for review! Excited to see this!

Can we also add a docs page in this directory that describes how to use context? https://github.com/facebook/relay/tree/main/website/docs/guides/relay-resolvers The [args](https://github.com/facebook/relay/blob/main/website/docs/guides/relay-resolvers/field-arguments.md) page is probably a good starting place.

Rust test failures on CI are unrelated. We have an ongoing issue where it is running out of disk space.

When trying to land this internally I found that it was going to be very difficult to rollout this change safely if we change how resolvers that don't read a...

I think today, in this case, I believe it will only ever return `undefined`. The `null` options is a side effect of how it's implemented. Revisiting the spec, to align...

Are you observing that a type param is currently required for `useFragment` in TypeScript? If so, I believe that is expected, and a current limitation. If you have a concrete...

How would your example look if there were other fields being read off of `product` in addition to the fragment spread?

@nzakas Thanks for the ping, I had a bit of writers block on the new conclusion, but I've reworked it and am now quite happy with it. Curious to hear...