Jordan Eldredge

Results 370 comments of Jordan Eldredge

I was also surprised by this behavior. Context is that I use `graphql-js` in [Grats](https://grats.capt.dev/) to validate that the schema the user has created is valid, and I am adding...

> the idea is that tooling would apply the directives by making changes to the schema, but the resulting schema would not "store" that these changes have happened Yeah, I...

It looks like TypeScript supports escaping `@` with `\@`. https://www.typescriptlang.org/play/?#code/PQKhCgAIUgJBTANog9pAOgAQC4At4BO8UMJkZJw42AngA7yQBiKaAvJAEQBCAhgZyA I think Grats should try to do the same. Let me see if I can figure out how.

Next step here will be to poke through TypeScript code to see exactly where/how this happens to see if there's a public function we can reuse or if we can...

@XiNiHa I think I've been hesitant to merge this for fear that there are some edge cases I'm not aware of here and that it could break things when I...

@XiNiHa Curious if you'll be able to add a flag here.

My sincere apologies. I've lost track of what we were trying to achieve here. Can you remind me?

Ah, from this: https://github.com/facebook/relay/pull/4692

Thanks for writing this up! Overall it looks right to me. Some concerns to track: 1. We need to convey the fact that these context values are not expected to...