Jordan Eldredge comments

Results 370 comments of


                                            Jordan Eldredge

Add node 18 in CI

Looks like the digital envelope issue is still present? ![Screenshot 2023-10-06 at 4 16 27 PM](https://github.com/facebook/relay/assets/162735/8ff96e9b-c41d-4ab7-995c-b1cab99f1c2e)

Typescript Validation for Resolver Types

This sounds right to me. Thanks for writing it up! One aside to note: We generally think these type assertions, while necessary today, lead to poor developer experience. A type...

Make workspace root lazy static to try to avoid cwd race condition

I think it’s a flaky situation due to integration tests running in that process changing the CWD in async tasks in a way that is unpredictable

Make workspace root lazy static to try to avoid cwd race condition

This landed as https://github.com/facebook/relay/commit/e1f2177c0cddff932fd04c90ccca068768b07dd8

Relay Developer Tools Chrome Extension unsupported

cc @Asymons

[WIP] Add an example project to the main Relay repo

The feedback here gave me pause. I think we won't aim to have a project checked into the main repository for now.

Docs: search behaves weirdly depending on the URL state

Thanks for flagging. I was just looking into why search seems broken. Let me see what I can figure out here.

Skeleton for store

There are definitely some edge cases with the userland approach, but I'm optimistic that it will be correct and performant enough to let us try the approach with some real...

Document multi-project config options

If the Relay compiler panics, that is a bug. Don’t have a minimal repro of a project that causes the compiler to panic like that which you can share? Jordan...

Add link to graphql mutations guide into sidebars

Could you also update the current version docs? https://github.com/facebook/relay/blob/main/website/versioned_sidebars/version-v15.0.0-sidebars.json